Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #17843 to 7.x: [Elastic-Agent] Correctly unmarshal Protocol #17866

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Cherry-pick #17843 to 7.x: [Elastic-Agent] Correctly unmarshal Protocol #17866

merged 1 commit into from
Apr 21, 2020

Conversation

ph
Copy link
Contributor

@ph ph commented Apr 21, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #17843 to 7.x branch. Original message:

The Protocol (https/http) was not correctly unmarshaly and assigned to
the value of the struct. Because of this the checking was trying to use
a plain text connection or a TLS enabled endpoint.

Fixes: #17841

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ph
Correctly unmarshal Protocol (#17843)
a1a015d 
The Protocol (https/http) was not correctly unmarshaly and assigned to
the value of the struct. Because of this the checking was trying to use
a plain text connection or a TLS enabled endpoint.

Fixes: #17841
(cherry picked from commit 0765f94)
@ph ph self-assigned this Apr 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@ph ph requested review from michalpristas and ruflin April 21, 2020 12:52
@ph ph mentioned this pull request Apr 21, 2020
Merged
6 tasks
@ph ph merged commit 9a21b66 into elastic:7.x Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas

Assignees

@ph ph

Labels
backport review [zube]: Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ph @elasticmachine @ruflin