Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metricbeat Kubernetes module and metricsets docs proposal #17636

Merged
merged 25 commits into from
May 6, 2020
Merged

Metricbeat Kubernetes module and metricsets docs proposal #17636

merged 25 commits into from
May 6, 2020

Conversation

eedugon
Copy link
Contributor

@eedugon eedugon commented Apr 9, 2020 •
edited
Loading

As agreed with @exekias , I'm adding in this PR some changes in Kubernetes module main document and in the majority of metricsets, including descriptions and configuration details for each one.

@cla-checker-service
Copy link

cla-checker-service bot commented Apr 9, 2020 •
edited
Loading

💚 CLA has been signed

@eedugon
Copy link
Contributor Author

eedugon commented Apr 10, 2020

@exekias , please review this PR. I'm going to need some help with some links, and I'm not totally sure that I have modified the right file.
I'm doubting between the file I have modified (metricbeat/docs/modules/kubernetes.asciidoc) and (metricbeat/module/kubernetes/_meta/docs.asciidoc)

@eedugon eedugon requested a review from exekias April 10, 2020 11:55
@andresrc andresrc added [zube]: Inbox Team:Platforms Label for the Integrations - Platforms team labels Apr 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@exekias
Copy link
Contributor

exekias commented Apr 21, 2020

@ChrsMark could you have a look to this one and help @eedugon to move it forward 🙏 ?

@ChrsMark
Copy link
Member

Hey @eedugon! The change must be applied on metricbeat/module/kubernetes/_meta/docs.asciidoc and then run mage update under metricbeat directory so as to automatically update metricbeat/docs/modules/kubernetes.asciidoc.

@eedugon eedugon added the needs_backport PR is waiting to be backported to other branches. label Apr 24, 2020
@eedugon
Copy link
Contributor Author

eedugon commented Apr 24, 2020

@ChrsMark , @exekias , I think i have fixed the CLA issue and I have made the changes into the right file.
As you said mage update also changed the final file too. This latest commit includes the content after running the update too.
Let me know your thoughts.

This would require also updating 7.x docs, but maybe it's better to review them in master (docs-preview doesn't work for me), and as soon as all looks great we can do the backport.

ChrsMark
ChrsMark reviewed Apr 27, 2020
View reviewed changes
@ChrsMark
Copy link
Member

Left some minor comments. Content looks good overall! I also restarted the failed docs job.

eedugon and others added 6 commits April 29, 2020 14:49
@eedugon @ChrsMark
Update metricbeat/module/kubernetes/_meta/docs.asciidoc
e4d948d 
Co-Authored-By: Chris Mark <chrismarkou92@gmail.com>
@eedugon @ChrsMark
Update metricbeat/module/kubernetes/_meta/docs.asciidoc
b810a61 
Co-Authored-By: Chris Mark <chrismarkou92@gmail.com>
@eedugon @ChrsMark
Update metricbeat/module/kubernetes/_meta/docs.asciidoc
e68005b 
Co-Authored-By: Chris Mark <chrismarkou92@gmail.com>
@eedugon @ChrsMark
Update metricbeat/docs/modules/kubernetes.asciidoc
98ebd57 
Co-Authored-By: Chris Mark <chrismarkou92@gmail.com>
@eedugon @ChrsMark
Update metricbeat/docs/modules/kubernetes.asciidoc
d80fc12 
Co-Authored-By: Chris Mark <chrismarkou92@gmail.com>
@eedugon @ChrsMark
Update metricbeat/docs/modules/kubernetes.asciidoc
a9915f8 
Co-Authored-By: Chris Mark <chrismarkou92@gmail.com>
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 29, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 3020
Skipped 756
Total 3776

@eedugon eedugon mentioned this pull request Apr 29, 2020
Closed
ChrsMark
ChrsMark approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ChrsMark ChrsMark merged commit fed44d5 into elastic:master May 6, 2020
ChrsMark pushed a commit to ChrsMark/beats that referenced this pull request May 6, 2020
@eedugon @ChrsMark
Metricbeat Kubernetes module and metricsets docs proposal (elastic#17636
eb44d6c 
)

(cherry picked from commit fed44d5)
@ChrsMark ChrsMark mentioned this pull request May 6, 2020
Merged
@ChrsMark ChrsMark removed the needs_backport PR is waiting to be backported to other branches. label May 6, 2020
ChrsMark pushed a commit to ChrsMark/beats that referenced this pull request May 6, 2020
@eedugon @ChrsMark
Metricbeat Kubernetes module and metricsets docs proposal (elastic#17636
677efea 
)

(cherry picked from commit fed44d5)
@ChrsMark ChrsMark mentioned this pull request May 6, 2020
Merged
ChrsMark pushed a commit to ChrsMark/beats that referenced this pull request May 6, 2020
@eedugon @ChrsMark
Metricbeat Kubernetes module and metricsets docs proposal (elastic#17636
d7986d2 
)

(cherry picked from commit fed44d5)
@ChrsMark ChrsMark mentioned this pull request May 6, 2020
Closed
ChrsMark added a commit that referenced this pull request May 6, 2020
@ChrsMark @eedugon
Metricbeat Kubernetes module and metricsets docs proposal (#17636) (#…
7fa197a 
…18291)

(cherry picked from commit fed44d5)

Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
ChrsMark added a commit that referenced this pull request May 6, 2020
@ChrsMark @eedugon
Metricbeat Kubernetes module and metricsets docs proposal (#17636) (#…
4e54f21 
…18290)

(cherry picked from commit fed44d5)

Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
ChrsMark pushed a commit to ChrsMark/beats that referenced this pull request May 6, 2020
@eedugon @ChrsMark
Metricbeat Kubernetes module and metricsets docs proposal (elastic#17636
cdc8243 
)

(cherry picked from commit fed44d5)
@ChrsMark ChrsMark mentioned this pull request May 6, 2020
Merged
ChrsMark added a commit that referenced this pull request May 7, 2020
@ChrsMark @eedugon
Metricbeat Kubernetes module and metricsets docs proposal (#17636) (#…
cdc3457 
…18310)

(cherry picked from commit fed44d5)

Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@ChrsMark @eedugon
Metricbeat Kubernetes module and metricsets docs proposal (elastic#17636
a8cccb8 
) (elastic#18291)

(cherry picked from commit e347457)

Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

@exekias exekias Awaiting requested review from exekias

Assignees
No one assigned
Labels
Team:Platforms Label for the Integrations - Platforms team v7.6.0 v7.7.0 v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eedugon @elasticmachine @exekias @ChrsMark @andresrc