Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jenkinsfile: Fix auditbeat check and add comments #17473

Merged
merged 2 commits into from
Apr 3, 2020

Conversation

urso
Copy link

@urso urso commented Apr 3, 2020

  • Bug
  • Enhancement

What does this PR do?

  1. Add isCheckedOSSCode to auditbeat build check.
  2. For x-pack builds with dependency on OSS build use env.BUILD_X_XPACK = env.BUILD_X || isChangedXPackDode
  3. Add comment to each check about dependencies and what the tests are supposed to run

Why is it important?

  1. we've been missing auditbeat CI runs on PRs. This ensures auditbeat tests are running when required
  2. points out dependencies of X-Pack code on OSS-code directly
  3. Not all contributors have experience with all Beats and test suite. Having comments on the checks documents the Beats authors intend, sharing the why with contributors not familiar with Beats.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@urso urso requested review from kuisathaverat and andrewkroh April 3, 2020 14:42
@urso urso added bug ci enhancement review Team:Services (Deprecated) Label for the former Integrations-Services team labels Apr 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

Jenkinsfile Outdated Show resolved Hide resolved
@urso urso merged commit 819938b into elastic:master Apr 3, 2020
@urso urso deleted the more-jenkinsfile-fixes branch April 3, 2020 17:45
urso pushed a commit to urso/beats that referenced this pull request Apr 3, 2020
* Jenkinsfile: Fix auditbeat check and add comments

* review

(cherry picked from commit 819938b)
@urso urso added the v7.8.0 label Apr 3, 2020
urso pushed a commit to urso/beats that referenced this pull request Apr 3, 2020
* Jenkinsfile: Fix auditbeat check and add comments

* review

(cherry picked from commit 819938b)
@urso urso added the v7.7.0 label Apr 3, 2020
urso pushed a commit that referenced this pull request Apr 7, 2020
* Jenkinsfile: Fix auditbeat check and add comments

* review

(cherry picked from commit 819938b)
urso pushed a commit that referenced this pull request Apr 9, 2020
* Jenkinsfile: Fix auditbeat check and add comments

* review

(cherry picked from commit 819938b)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
elastic#17482)

* Jenkinsfile: Fix auditbeat check and add comments

* review

(cherry picked from commit 4899f14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci enhancement review Team:Services (Deprecated) Label for the former Integrations-Services team v7.7.0 v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants