[Agent] Handle kill nicely #17318
Merged
[Agent] Handle kill nicely #17318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ingest-management (Project:fleet) |
ph
approved these changes
Apr 3, 2020
| @@ -155,7 +156,8 @@ func (f *fleetGateway) worker() { | |||
|
|
|||
| func (f *fleetGateway) doExecute() (*fleetapi.CheckinResponse, error) { | |||
| f.backoff.Reset() | |||
| for { | |||
| for f.bgContext.Err() == nil { | |||
| fmt.Println(">>> loop: ", f.bgContext.Err()) | |||
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
Apr 15, 2020
[Agent] Improved cancellation of agent (elastic#17318) (cherry picked from commit 65b5255)
6 tasks
michalpristas
added a commit
that referenced
this pull request
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes to some context handles.
TBH i dont like this solution, and i think we will need to udnertake some more complex refactor to behave nicer, we have a lot of moving parts and background workers which are interconnected what makes this a bit complicated to introduce context as a second step (we started completely without context)
I'm ok to get this in as a quick fix but under a condition of further refactor, so i'm publishing this as a draft.
Why is it important?
To speed up ctrl c kill
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.