Use Go 1.13.1 runtime on GCP for cloud functions #17180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/integrations-services (Team:Services) |
v1v
reviewed
Mar 24, 2020
andrewkroh
approved these changes
Mar 24, 2020
| @@ -21,7 +21,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| runtime = "go111" // Golang 1.11 | |||
| runtime = "go113" // Golang 1.11 | |||
There was a problem hiding this comment.
Suggested change
| runtime = "go113" // Golang 1.11 | |
| runtime = "go113" // Golang version. |
74286eb to
499d22f
Compare
Co-Authored-By: Victor Martinez <victormartinezrubio@gmail.com>
Co-Authored-By: Victor Martinez <victormartinezrubio@gmail.com>
0aeec83 to
d17fb64
Compare
kvch
added a commit
to kvch/beats
that referenced
this pull request
Mar 24, 2020
This PR changes the runtime of Google Cloud Functions provided by Functionbeat to 1.13.1. Furthermore, a test is added to the CIs to check if the cloud functions can be built using Go 1.13.1. Previously, we had no check to catch if we had broken something in the GCP functions. - Closes elastic#16827 (cherry picked from commit b82b9db)
2 tasks
kvch
added a commit
that referenced
this pull request
Mar 25, 2020
This PR changes the runtime of Google Cloud Functions provided by Functionbeat to 1.13.1. Furthermore, a test is added to the CIs to check if the cloud functions can be built using Go 1.13.1. Previously, we had no check to catch if we had broken something in the GCP functions. - Closes #16827 (cherry picked from commit b82b9db)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the runtime of Google Cloud Functions provided by Functionbeat to 1.13.1. Furthermore, a test is added to Travis CI to check if the cloud functions can be built using Go 1.13.1.
One of the limitations of this PR is that no check is added to Jenkins yet.Why is it important?
Previously, we had no check to catch if we had broken something in the GCP functions.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature worksRelated issues