Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compose up retries in python tests #17120

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Mar 19, 2020

Exception is being incorrectly handled, so retries don't work, and provoke misleading errors like:

name 'e' is not defined

Fixes code introduced in #16921

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@jsoriano
Copy link
Member Author

Thanks @sayden for reporting and reviewing!

@jsoriano
Copy link
Member Author

I have added this fix in the backport of #16921, that is still pending of review.

@jsoriano jsoriano merged commit 450067d into elastic:master Mar 19, 2020
@jsoriano jsoriano deleted the fix-compose-up-retries branch March 19, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug review Team:Integrations Label for the Integrations team :Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants