Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add GCP settings #16228

Merged
merged 5 commits into from
Feb 14, 2020
Merged

[docs] Add GCP settings #16228

merged 5 commits into from
Feb 14, 2020

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Feb 11, 2020

Adds documentation for Google Cloud Platform support in Functionbeat.

The doc preview is here: http://beats_16228.docs-preview.app.elstc.co/guide/en/beats/functionbeat/master/index.html

@dedemorton dedemorton added docs in progress Pull request is currently in progress. labels Feb 11, 2020
@dedemorton dedemorton marked this pull request as ready for review February 13, 2020 02:47
@dedemorton dedemorton requested a review from kvch February 13, 2020 02:47
@dedemorton
Copy link
Contributor Author

@kvch I still need to iron out the topic that describes deployment because I couldn't quite get the deployment with Google Cloud Deployment Manager working. Maybe you have some tips?

Anyhow, you can start reviewing the other sections and also respond to the questions that I raised for reviewers. Some of the questions are in the deployment topic (it would help me out if you can answer them and maybe even provide more guidance on what needs to change in the exported YAML to get things working).

@dedemorton
Copy link
Contributor Author

Note that I've removed the review questions and added them to a follow-up issue so we can address them prior to GA of the feature: #16337

@dedemorton dedemorton merged commit b205c38 into elastic:master Feb 14, 2020
@dedemorton dedemorton deleted the add_gcp_docs branch February 14, 2020 19:28
dedemorton added a commit to dedemorton/beats that referenced this pull request Feb 14, 2020
dedemorton added a commit to dedemorton/beats that referenced this pull request Feb 14, 2020
dedemorton added a commit that referenced this pull request Feb 14, 2020
dedemorton added a commit that referenced this pull request Feb 14, 2020
kvch pushed a commit to kvch/beats that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs in progress Pull request is currently in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants