Kubernetes: node autodiscover, add InternalIP #15930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
reviewed
Jan 30, 2020
There was a problem hiding this comment.
At first glance it looks a bit complicated and I was thinking for a while how you can make this straighforward...
What do you think about splitting responsibilities here into half, firstly - find external and internal IP, secondly - take a decision about IP address. You may even don't need a comment :)
| } | ||
|
|
||
| // getAddress returns an IP address from a kubernetes node. | ||
| // | ||
| // It will use external IP if existing, falling back to Internal IP if not, |
There was a problem hiding this comment.
nit: either InternalIP or internal IP
| } | ||
|
|
||
| // getAddress returns an IP address from a kubernetes node. |
|
With this change we have an order of preference for the address we return. We should probably document it, WDYT? Would it make sense to also expose both internal and external IPs in other fields of the event? |
mtojek
approved these changes
Jan 30, 2020
odacremolbap
pushed a commit
to odacremolbap/beats
that referenced
this pull request
Jan 31, 2020
* use any node ip (cherry picked from commit 6273589)
odacremolbap
pushed a commit
that referenced
this pull request
Feb 3, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
complementary to #14738 (comment)
Autodiscover for nodes should use not only the external IP but also the internal one.