Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for publisher spool encode and decode. #15534

Merged
merged 3 commits into from
Jan 15, 2020
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 74 additions & 0 deletions libbeat/publisher/queue/spool/codec_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
// Licensed to Elasticsearch B.V. under one or more contributor
// license agreements. See the NOTICE file distributed with
// this work for additional information regarding copyright
// ownership. Elasticsearch B.V. licenses this file to you under
// the Apache License, Version 2.0 (the "License"); you may
// not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

package spool

import (
"testing"
"time"

"github.com/stretchr/testify/assert"

"github.com/elastic/beats/libbeat/beat"
"github.com/elastic/beats/libbeat/common"
"github.com/elastic/beats/libbeat/publisher"
)

func TestEncodeDecode(t *testing.T) {
tests := map[string]codecID{
"jsob": codecJSON,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"json" :-)

"ubjson": codecUBJSON,
"cborl": codecCBORL,
}

event := publisher.Event{
Content: beat.Event{
Timestamp: time.Now().Round(0),
Fields: common.MapStr{
"time": time.Now().UTC().Round(time.Millisecond),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(here and below) Minor in this case since the test doesn't really rely on it, but tests should be deterministic: use fixed time.Time values as initial inputs rather than time.Now()

"commontime": common.Time(time.Now().UTC().Round(time.Millisecond)),
},
},
}
expected := publisher.Event{
Content: beat.Event{
Timestamp: event.Content.Timestamp,
Fields: common.MapStr{
"time": event.Content.Fields["time"].(time.Time).Format(time.RFC3339Nano),
"commontime": event.Content.Fields["commontime"].(common.Time).String(),
},
},
}

for name, codec := range tests {
t.Run(name, func(t *testing.T) {
encoder, err := newEncoder(codec)
assert.NoError(t, err)

encoded, err := encoder.encode(&event)
assert.NoError(t, err)

decoder := newDecoder()
decoder.buf = encoded

observed, err := decoder.Decode()
assert.NoError(t, err)

assert.Equal(t, expected, observed)
})
}
}