Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Add Google Cloud Platform module #14829
[Metricbeat] Add Google Cloud Platform module #14829
Changes from all commits
8d9ed54
9a5e4e3
a4969cd
1c787b1
410b901
b562f27
57f956a
e01a700
39f9ed9
af4dd18
f17f4c6
3f33340
13a00ed
94c2b95
87435f5
c84bc76
e12112f
8573777
25d1e14
906ceb4
915bf18
48f7ba2
154108e
79d4955
3191352
33894e8
d5f93c4
8d93a3d
24ce9c8
55fdb51
d57231a
03d9c28
6ad3133
8a079a0
44cf435
6a3accf
7530216
d12ae42
c8a974e
a3e6f6a
5fdf780
68b906c
242262c
0c685b7
f61f051
fd455c9
bf5f06e
9edadd7
f12fdc7
45f33e6
c96397a
b83ff57
5ed657f
242ace3
71d9cff
07fda7c
5a3cac1
edff0e9
6e69878
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this section, this is something usually asked.
Would it make sense to mention something about the recommended periods, or about how GCP charges the requests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a short section about periods but I think it's better to not mention many things that appear directly (and better explained) in GCP docs because we risk to get our docs outdated. I feel like it's safe to assume that if they are worried about how GCP charges them, they'll check GCP and the "under the hood" section will gives them the overall idea of how it might impact them