[Filebeat] Decode hex values in auditd log messages #14471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed pipeline from json to yaml so it will be easier to see diffs in the painless script
- Added keys that were listed as escaped in auparse/typetab.h to the list of possible keys that might need to be decoded. - changed convertHexToString in pipeline to use carat notation for control character (tab, delete, new line, etc) - chnaged convertHexToString to return original hex string if one of the character that trigger encoding in the auditd package isn't found. In this case data should probably remain as hex.
|
Pinging @elastic/siem (Team:SIEM) |
andrewkroh
reviewed
Nov 12, 2019
andrewkroh
approved these changes
Nov 12, 2019
|
I recommend including |
adriansr
approved these changes
Nov 12, 2019
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Nov 13, 2019
* Convert auditd pipeline to yaml
- changed pipeline from json to yaml so it will be easier to see diffs
in the painless script
* hex decode value fields in auditd module (elastic#14290)
- Added keys that were listed as escaped in auparse/typetab.h
to the list of possible keys that might need to be decoded.
- changed convertHexToString in pipeline to use carat notation
for control character (tab, delete, new line, etc)
- changed convertHexToString to return original hex string if one
of the character that trigger encoding in the auditd package
isn't found. In this case data should probably remain as hex.
* Add CHANGELOG entry for decoding hex values in auditd module
Fixes elastic#14290
(cherry picked from commit f693d2d)
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Nov 13, 2019
* Convert auditd pipeline to yaml
- changed pipeline from json to yaml so it will be easier to see diffs
in the painless script
* hex decode value fields in auditd module (elastic#14290)
- Added keys that were listed as escaped in auparse/typetab.h
to the list of possible keys that might need to be decoded.
- changed convertHexToString in pipeline to use carat notation
for control character (tab, delete, new line, etc)
- changed convertHexToString to return original hex string if one
of the character that trigger encoding in the auditd package
isn't found. In this case data should probably remain as hex.
* Add CHANGELOG entry for decoding hex values in auditd module
Fixes elastic#14290
(cherry picked from commit f693d2d)
leehinman
added a commit
that referenced
this pull request
Nov 14, 2019
* Convert auditd pipeline to yaml
- changed pipeline from json to yaml so it will be easier to see diffs
in the painless script
* hex decode value fields in auditd module (#14290)
- Added keys that were listed as escaped in auparse/typetab.h
to the list of possible keys that might need to be decoded.
- changed convertHexToString in pipeline to use carat notation
for control character (tab, delete, new line, etc)
- changed convertHexToString to return original hex string if one
of the character that trigger encoding in the auditd package
isn't found. In this case data should probably remain as hex.
* Add CHANGELOG entry for decoding hex values in auditd module
Fixes #14290
(cherry picked from commit f693d2d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert auditd pipeline to yaml and decode hex values listed in auditd source code.
Fixes #14290.