Add attack_pattern_kql field to MISP threat indicators #14470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem (Team:SIEM) |
andrewkroh
reviewed
Nov 13, 2019
| evt.Put("source.ip", ip); | ||
| break; | ||
| case "link": | ||
| attackPattern = '[' + 'url.full = ' + '\'' + v + '\'' + ']'; | ||
| attackPattern = '[' + 'url:full = ' + '\'' + v + '\'' + ']'; | ||
| attackPatternKQL = 'url.full: ' + '"' + v + '"'; |
There was a problem hiding this comment.
You might also want to search the http.request.referrer URL?
There was a problem hiding this comment.
The http record, that has the referrer URL as the url.full field, should have already matched the query. So this might not be needed. Otherwise, we will have duplicates.
|
Just a note: For the "AND" query, I will keep the relevant fields set; but for "OR" query, I will not set the fields since it will be taken as "AND". |
|
jenkins, test this |
andrewkroh
approved these changes
Nov 14, 2019
alakahakai
pushed a commit
that referenced
this pull request
Nov 21, 2019
* Add attack_pattern_kql field to MISP threat indicators (#14470)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add attack_pattern_kql field to MISP threat indicators, so that detection engine can use it as threat indicator rules.