[Heartbeat] Remove host.name field from events #14140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field should never have been present, and is a distraction from the observer.* fields. Resolves elastic#12107
|
Pinging @elastic/uptime (:uptime) |
ruflin
reviewed
Oct 21, 2019
| @@ -34,7 +37,11 @@ var Name = "heartbeat" | |||
| var RootCmd *cmd.BeatsRootCmd | |||
|
|
|||
| func init() { | |||
| RootCmd = cmd.GenRootCmdWithSettings(beater.New, instance.Settings{Name: Name}) | |||
| settings := instance.Settings{ | |||
There was a problem hiding this comment.
Don't remember anymore the full affect of this. Does it only remove the host.* name fields or any other fields too?
There was a problem hiding this comment.
This should just remove the default host.name field. In comparison to this line, which I think the default for a beat, the difference is just the lack of WithHost.
There was a problem hiding this comment.
That's my understanding as well
|
@ruflin thanks for the review! Added the CHANGELOG entry, also cleaned up some imports I missed the first time. |
ruflin
approved these changes
Oct 22, 2019
|
@ruflin CI failures are unrelated |
jorgemarey
pushed a commit
to jorgemarey/beats
that referenced
this pull request
Jun 8, 2020
This field should never have been present, and is a distraction from the observer.* fields. Resolves elastic#12107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field should never have been present, and is a distraction from the
observer.* fields.
Resolves #12107