Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshots instead of nigtlies #1400

Merged
merged 1 commit into from
Apr 15, 2016
Merged

Snapshots instead of nigtlies #1400

merged 1 commit into from
Apr 15, 2016

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Apr 15, 2016

  • Snapshot/nigtlies no longer contain the date in the file names
  • We will publish now only one SNAPSHOT, the latest one
  • Inside all packages, there is a .build_hash.txt file containing the git hash so we can track the moment when the snapshot was created.
  • The default is to add -SNAPSHOT, you can disable it by calling dev-tools/deploy --no-snapshot or by make SNAPSHOT=no in dev-tools/packer

In addition, this PR simplifies a bit the packaging process:

  • No longer use xgo, rather just call the docker commands directly. This
    is not a lot more complex and it's easier to modify the command (e.g add
    another env variable) when needed.
  • The logic to copy nightlies to latest is no longer needed
  • the deb_version and rpm_version are replaced with a sed that replaces -
    with ~ in the platform scripts
  • No longer use docker cp to copy the artifacts over, we already have a
    shared volume and that's faster.

@tsg tsg added the review label Apr 15, 2016
@@ -1,32 +1,33 @@
DATE:=$(shell date +%y%m%d%H%M%S)
BUILDID?=$(DATE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be changed to be the git commit hash?

@andrewkroh
Copy link
Member

Jenkins beats-package job will need to be updated to remove the following logic from the build command

# In file names, $BUILDID is replaced with "latest" to create that latest artifacts for S3.
export BUILDID=$(git rev-parse --short HEAD)
ver=$(python ./dev-tools/get_version | sed "s/-\w\+/-nightly${BUILDID}/")
python ./dev-tools/set_version $ver
python ./dev-tools/deploy

* Snapshot/nigtlies no longer contain the date in the file names
* We will publish now only one SNAPSHOT, the latest one
* Inside all packages, there is a `.build_hash.txt` file containing the
  git hash so we can track the moment when the snapshot was created.

In addition, this PR simplifies a bit the packaging process:

* No longer use xgo, rather just call the docker commands directly. This
  is not a lot more complex and it's easier to modify the command (e.g add
  another env variable) when needed.
* The logic to copy nightlies to latest is no longer needed
* the deb_version and rpm_version are replaced with a sed that replaces -
  with ~ in the platform scripts
* No longer use `docker cp` to copy the artifacts over, we already have a
  shared volume and that's faster.
@andrewkroh andrewkroh merged commit 515dd68 into elastic:master Apr 15, 2016
@tsg tsg deleted the new_snapshots branch August 25, 2016 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants