-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add panic recover to JS script processor #13746
Merged
andrewkroh
merged 2 commits into
elastic:master
from
andrewkroh:feature/js-processor-panic-recover-logging
Sep 24, 2019
Merged
Add panic recover to JS script processor #13746
andrewkroh
merged 2 commits into
elastic:master
from
andrewkroh:feature/js-processor-panic-recover-logging
Sep 24, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
approved these changes
Sep 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Probably worth a changelog entry?
adriansr
approved these changes
Sep 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Agree on the need for a CHANGELOG entry
To help debug panics in the script processor add a `recover()` statement that will log the event being processed.
andrewkroh
force-pushed
the
feature/js-processor-panic-recover-logging
branch
from
September 24, 2019 13:50
78d2142
to
69652da
Compare
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Oct 3, 2019
To help debug panics in the script processor add a `recover()` statement that will log the event being processed. (cherry picked from commit 256e112)
andrewkroh
added a commit
that referenced
this pull request
Oct 7, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
To help debug panics in the script processor add a `recover()` statement that will log the event being processed. (cherry picked from commit e2e641e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help debug panics in the script processor add a
recover()
statement that will log the event being processed.