-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat]Kubernetes: add resource quotas via kube-state-metrics #13693
[Metricbeat]Kubernetes: add resource quotas via kube-state-metrics #13693
Conversation
metricbeat/module/kubernetes/state_resourcequota/state_resourcequota_test.go
Show resolved
Hide resolved
metricbeat/module/kubernetes/state_resourcequota/state_resourcequota.go
Outdated
Show resolved
Hide resolved
This is reviewable now, although the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, only a couple of comments and a proposal that may be not so good depending on what we can do with our current helpers.
metricbeat/module/kubernetes/state_resourcequota/state_resourcequota.go
Outdated
Show resolved
Hide resolved
@odacremolbap do you mean 7.5.0? |
Is it targeting |
Oh right, I thought that you meant the version where this change would be released 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please remove the commented out fetching code.
metricbeat/module/kubernetes/state_resourcequota/state_resourcequota.go
Outdated
Show resolved
Hide resolved
jenkins, test this |
jenkins, test this |
Adding kube-state-metrics'
ResourceQuota
supportSee: #6659
This PR brings resource quota information to the kubernetes module.
Test instructions for setting up the environment are located at https://github.com/elastic/beats/blob/master/metricbeat/module/kubernetes/_meta/test/docs/README.md including a
ResourceQuota
example at the objects subfolder.ResourceQuota PR Check:
Answer is no
Answer is no
Generic PR Check: