Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat]Kubernetes: add resource quotas via kube-state-metrics #13693

Conversation

odacremolbap
Copy link
Contributor

@odacremolbap odacremolbap commented Sep 16, 2019

Adding kube-state-metrics' ResourceQuota support

See: #6659

This PR brings resource quota information to the kubernetes module.
Test instructions for setting up the environment are located at https://github.com/elastic/beats/blob/master/metricbeat/module/kubernetes/_meta/test/docs/README.md including a ResourceQuota example at the objects subfolder.

ResourceQuota PR Check:

  • ScopeSelector: do they create prometheus labels when used?
    Answer is no
  • Scope: do they create prometheus labels when used?
    Answer is no

Generic PR Check:

  • Changelog entry
  • Golden Files
  • Manual test info
  • Config reference

@odacremolbap odacremolbap requested a review from a team as a code owner September 16, 2019 10:56
@odacremolbap odacremolbap self-assigned this Sep 16, 2019
@odacremolbap odacremolbap added Team:Integrations Label for the Integrations team containers Related to containers use case in progress Pull request is currently in progress. Metricbeat Metricbeat v7.5.0 labels Sep 16, 2019
@odacremolbap odacremolbap added review and removed in progress Pull request is currently in progress. labels Sep 16, 2019
@odacremolbap
Copy link
Contributor Author

This is reviewable now, although the Changelog entry is still needed, current one is still targeting 7.4.0

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, only a couple of comments and a proposal that may be not so good depending on what we can do with our current helpers.

@jsoriano
Copy link
Member

This is reviewable now, although the Changelog entry is still needed, current one is still targeting 7.4.0

@odacremolbap do you mean 7.5.0?

@odacremolbap
Copy link
Contributor Author

This is reviewable now, although the Changelog entry is still needed, current one is still targeting 7.4.0

@odacremolbap do you mean 7.5.0?

Is it targeting 7.5.0 now?
I can see this issue #13698 open. I don't know the process, but I guess I need to wait for it to roll over to add this change.

@jsoriano
Copy link
Member

This is reviewable now, although the Changelog entry is still needed, current one is still targeting 7.4.0

@odacremolbap do you mean 7.5.0?

Is it targeting 7.5.0 now?
I can see this issue #13698 open. I don't know the process, but I guess I need to wait for it to roll over to add this change.

Oh right, I thought that you meant the version where this change would be released 🙂

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please remove the commented out fetching code.

@odacremolbap
Copy link
Contributor Author

jenkins, test this

@odacremolbap
Copy link
Contributor Author

jenkins, test this

@odacremolbap odacremolbap merged commit 1058daf into elastic:master Oct 7, 2019
@odacremolbap odacremolbap deleted the task/kube-state-metrics-resource-quota branch October 7, 2019 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
containers Related to containers use case Metricbeat Metricbeat review Team:Integrations Label for the Integrations team v7.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants