Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker.cpu.system.pct calculation #13691

Merged
merged 4 commits into from
Sep 17, 2019
Merged

Fix docker.cpu.system.pct calculation #13691

merged 4 commits into from
Sep 17, 2019

Conversation

ChrsMark
Copy link
Member

Fixes: #13674

@ChrsMark
Fix docker.cpu.system.pct calculation
05b4e41 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark requested a review from a team as a code owner September 16, 2019 10:00
@ChrsMark ChrsMark self-assigned this Sep 16, 2019
@ChrsMark ChrsMark added Team:Integrations Label for the Integrations team containers Related to containers use case [zube]: In Review review labels Sep 16, 2019
@ChrsMark
Fix test
9d3c42d 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark mentioned this pull request Sep 16, 2019
Merged
5 tasks
@ChrsMark
Copy link
Member Author

jenkins, test this again please

jsoriano
jsoriano reviewed Sep 16, 2019
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you please add a changelog entry?

@ChrsMark
Add changelog
0c5a9ee 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark requested a review from jsoriano September 17, 2019 07:05
jsoriano
jsoriano approved these changes Sep 17, 2019
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can ignore my comment, not so important, as you prefer 🙂

CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@ChrsMark @jsoriano
Update CHANGELOG.next.asciidoc
9cb31dc 
Co-Authored-By: Jaime Soriano Pastor <jaime.soriano@elastic.co>
@jsoriano
Copy link
Member

jsoriano commented Sep 17, 2019 •
edited
Loading

@ChrsMark I think we can go on merging this PR and make further improvements in future PRs.

@ChrsMark ChrsMark merged commit a28362d into elastic:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@ChrsMark ChrsMark

Labels
containers Related to containers use case review Team:Integrations Label for the Integrations team v7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible wrong calculation of CPU percentage
3 participants
@ChrsMark @jsoriano @andresrc