Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABANDONED] Prometheus Dashboard for Metricbeat #13121

Merged
merged 2 commits into from
Jul 31, 2019
Merged

[ABANDONED] Prometheus Dashboard for Metricbeat #13121

merged 2 commits into from
Jul 31, 2019

Conversation

sorantis
Copy link
Contributor

@sorantis sorantis commented Jul 31, 2019 •
edited
Loading

New PR: #13126

@sorantis sorantis requested a review from a team as a code owner July 31, 2019 13:12
@ghost
Copy link

ghost commented Jul 31, 2019

Hi @sorantis, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@exekias
Copy link
Contributor

exekias commented Jul 31, 2019

Thank you! do you have an screenshot for the dashboard? it would be interesting to add it here so we can show it in the docs

@exekias
Copy link
Contributor

exekias commented Jul 31, 2019

We will also need to explain that this dashboard is for metrics collected from a Prometheus server

@sorantis
Copy link
Contributor Author

@exekias , yes there's a screenshot in the related issue #13120

@exekias exekias added Team:Integrations Label for the Integrations team enhancement Metricbeat Metricbeat labels Jul 31, 2019
@sorantis sorantis requested a review from a team as a code owner July 31, 2019 14:29
@sorantis sorantis merged commit 4ee5070 into elastic:master Jul 31, 2019
sorantis added a commit that referenced this pull request Jul 31, 2019
@sorantis
Revert "Prometheus Dashboard for Metricbeat (#13121)"
b6a86d4 
This reverts commit 4ee5070.
@sorantis sorantis mentioned this pull request Jul 31, 2019
Merged
sorantis added a commit that referenced this pull request Jul 31, 2019
@sorantis
Revert "Prometheus Dashboard for Metricbeat (#13121)" (#13124)
ce9f6a3 
This reverts commit 4ee5070.
@sorantis
Copy link
Contributor Author

Accidentally merged this PR.

@sorantis sorantis changed the title Prometheus Dashboard for Metricbeat [ABANDONED] Prometheus Dashboard for Metricbeat Jul 31, 2019
@sorantis sorantis deleted the 13120-prometheus-module branch July 31, 2019 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Metricbeat Metricbeat Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorantis @exekias