Fix a crash under Windows when fetching process information #12833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
approved these changes
Jul 9, 2019
|
CI failure unrelated |
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Jul 9, 2019
…12833) This updates gosigar to v0.10.4 and go-sysinfo to v1.0.2. Both releases fix a similar bug under Windows when fetching the command-line of a running process: The offending code expected the command-line strings read from a target process to contain a null character as a terminator. However, this is not always true, and sometimes a terminator needs to be added. Most of the time the missing terminator wasn't an issue due to the runtime allocating extra space for the string, but in some extreme cases it caused a crash. This bug manifested in: Metricbeat's system/process metricset. It is also used by: Auditbeat's system/process. Packetbeat's process monitor (disabled by default). The add_process_metadata processor. Beats monitoring. libbeat/cmd/instance/beat.go Fixes elastic#12826 (cherry picked from commit 2b6763d)
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Jul 9, 2019
…12833) This updates gosigar to v0.10.4 and go-sysinfo to v1.0.2. Both releases fix a similar bug under Windows when fetching the command-line of a running process: The offending code expected the command-line strings read from a target process to contain a null character as a terminator. However, this is not always true, and sometimes a terminator needs to be added. Most of the time the missing terminator wasn't an issue due to the runtime allocating extra space for the string, but in some extreme cases it caused a crash. This bug manifested in: Metricbeat's system/process metricset. It is also used by: Auditbeat's system/process. Packetbeat's process monitor (disabled by default). The add_process_metadata processor. Beats monitoring. libbeat/cmd/instance/beat.go Fixes elastic#12826 (cherry picked from commit 2b6763d)
adriansr
added a commit
that referenced
this pull request
Jul 9, 2019
…12837) This updates gosigar to v0.10.4 and go-sysinfo to v1.0.2. Both releases fix a similar bug under Windows when fetching the command-line of a running process: The offending code expected the command-line strings read from a target process to contain a null character as a terminator. However, this is not always true, and sometimes a terminator needs to be added. Most of the time the missing terminator wasn't an issue due to the runtime allocating extra space for the string, but in some extreme cases it caused a crash. This bug manifested in: Metricbeat's system/process metricset. It is also used by: Auditbeat's system/process. Packetbeat's process monitor (disabled by default). The add_process_metadata processor. Beats monitoring. libbeat/cmd/instance/beat.go Fixes #12826 (cherry picked from commit 2b6763d)
adriansr
added a commit
that referenced
this pull request
Jul 9, 2019
…ocess information (#12835) This updates gosigar to v0.10.4 and go-sysinfo to v1.0.2. Both releases fix a similar bug under Windows when fetching the command-line of a running process: The offending code expected the command-line strings read from a target process to contain a null character as a terminator. However, this is not always true, and sometimes a terminator needs to be added. Most of the time the missing terminator wasn't an issue due to the runtime allocating extra space for the string, but in some extreme cases it caused a crash. This bug manifested in: Metricbeat's system/process metricset. It is also used by: Auditbeat's system/process. Packetbeat's process monitor (disabled by default). The add_process_metadata processor. Beats monitoring. libbeat/cmd/instance/beat.go Fixes #12826 (cherry picked from commit 2b6763d)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…12833) (elastic#12837) This updates gosigar to v0.10.4 and go-sysinfo to v1.0.2. Both releases fix a similar bug under Windows when fetching the command-line of a running process: The offending code expected the command-line strings read from a target process to contain a null character as a terminator. However, this is not always true, and sometimes a terminator needs to be added. Most of the time the missing terminator wasn't an issue due to the runtime allocating extra space for the string, but in some extreme cases it caused a crash. This bug manifested in: Metricbeat's system/process metricset. It is also used by: Auditbeat's system/process. Packetbeat's process monitor (disabled by default). The add_process_metadata processor. Beats monitoring. libbeat/cmd/instance/beat.go Fixes elastic#12826 (cherry picked from commit 3374b3a)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…hing process information (elastic#12835) This updates gosigar to v0.10.4 and go-sysinfo to v1.0.2. Both releases fix a similar bug under Windows when fetching the command-line of a running process: The offending code expected the command-line strings read from a target process to contain a null character as a terminator. However, this is not always true, and sometimes a terminator needs to be added. Most of the time the missing terminator wasn't an issue due to the runtime allocating extra space for the string, but in some extreme cases it caused a crash. This bug manifested in: Metricbeat's system/process metricset. It is also used by: Auditbeat's system/process. Packetbeat's process monitor (disabled by default). The add_process_metadata processor. Beats monitoring. libbeat/cmd/instance/beat.go Fixes elastic#12826 (cherry picked from commit 3374b3a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates gosigar to v0.10.4 and go-sysinfo to v1.0.2.
Both releases fix a similar bug under Windows when fetching the command-line of a running process:
The offending code expected the command-line strings read from a target process to contain a null character as a terminator. However, this is not always true, and sometimes a terminator needs to be added. Most of the time the missing terminator wasn't an issue due to the runtime allocating extra space for the string, but in some extreme cases it caused a crash.
This bug manifested in:
It is also used by:
Fixes #12826