Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auditbeat] Process dataset: Do not show non-root warning on Windows #12740

Merged
merged 2 commits into from
Jul 2, 2019

Conversation

cwurm
Copy link
Contributor

@cwurm cwurm commented Jul 1, 2019

os.Geteuid() always returns -1 on Windows, so it is not an effective check for administrative privileges then.

This PR just removes the warning on Windows, the message has no impact on the data collection.

@cwurm cwurm requested a review from a team as a code owner July 1, 2019 15:52
@elasticmachine
Copy link
Collaborator

Pinging @elastic/secops

Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwurm cwurm merged commit ba9c79e into elastic:master Jul 2, 2019
@cwurm cwurm deleted the process_fix_warning_on_windows branch July 2, 2019 16:06
@cwurm cwurm added the v6.8.2 label Jul 2, 2019
@cwurm cwurm added the v7.3.0 label Jul 2, 2019
cwurm pushed a commit to cwurm/beats that referenced this pull request Jul 3, 2019
…tic#12740)

Remove the non-root warning on Windows as `os.Geteuid()` always returns `-1`.

(cherry picked from commit ba9c79e)
cwurm pushed a commit that referenced this pull request Jul 3, 2019
Remove the non-root warning on Windows as `os.Geteuid()` always returns `-1`.

(cherry picked from commit ba9c79e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants