-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Add nil pointer checks for docker NetworkSettings #12628
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, can you add a changelog?
I always forget the changelog... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (besides changelog) 👍
Co-Authored-By: Carlos Pérez-Aradros Herce <exekias@gmail.com>
Not sure what's up with the CI failure. Looks like a fields.yml issue, but those haven't been touched? |
This was @exekias and I's idea, as a quick hotfix to deal with #12524.
See also vmware/vic#8564
We decided at this point we don't need full support for VIC, but It can't hurt to add more nil pointer checks.
I'm still trying to figure out to what degree this would impact other parts of the docker module. I don't have a lot of experience setting up vSphere, which isn't helping.