Continuation of: Adriansr fix mb windows procs #12301 (#12475) #12527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#12475) * [Metricbeat] Fix system/process* metricsets under Windows This updates vendored elastic/gosigar to v0.10.3, which addresses an issue when listing processes under a non-privileged Windows user. For the system/process metricset, only processes belonging to the user under which Metricbeat is running were reported. For the system/process_summary metricset, process belonging to other users were reported as unknown state. This fix will make Metricbeat able to report all processes, but information about which users owns those processes will be missing. Fixes elastic#12301 * Added test func in order to provide more information on the failing match * Fix build error * Removed test func, correcting access rights in sigar_windows file (gosigar pr will follow), test only * Revert test changes, return debug message for process.getDetails * Replaced the PR number in the changelog * Adding selector to log debug message * Wrong type for pid in debug message (cherry picked from commit 08b5c38)
adriansr
reviewed
Jun 13, 2019
There was a problem hiding this comment.
For backports we use the script under dev-tools/cherrypick_pr, which creates the PR for you (right now seems that it's broken).
It's better if you stick to the format that it creates:
title: Cherry-pick #NNNN to 7.X: {original title}
message:
Cherry-pick of PR #NNNN to 7.X branch. Original message:
{original message}
| @@ -134,6 +134,8 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d | |||
| - Fixed RabbitMQ `queue` metricset gathering when `consumer_utilisation` is set empty at the metrics source {pull}12089[12089] | |||
| - Fix direction of incoming IPv6 sockets. {pull}12248[12248] | |||
| - Ignore prometheus metrics when their values are NaN or Inf. {pull}12084[12084] {issue}10849[10849] | |||
| - In the kibana/stats metricset, only log error (don't also index it) if xpack is enabled. {pull}12265[12265] | |||
There was a problem hiding this comment.
This changelog entry sneaked in. Happens frequently with backports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to 7.2 #12475 (comment)
This updates vendored elastic/gosigar to v0.10.3, which addresses an
issue when listing processes under a non-privileged Windows user.
For the system/process metricset, only processes belonging to the user
under which Metricbeat is running were reported.
For the system/process_summary metricset, process belonging to other
users were reported as unknown state.
This fix will make Metricbeat able to report all processes, but
information about which users owns those processes will be missing.
Fixes #12301
Added test func in order to provide more information on the failing match
Fix build error
Removed test func, correcting access rights in sigar_windows file (gosigar pr will follow), test only
Revert test changes, return debug message for process.getDetails
Replaced the PR number in the changelog
Adding selector to log debug message
Wrong type for pid in debug message
(cherry picked from commit 08b5c38)