Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filebeat] Cisco ASA module #11171

Merged
merged 16 commits into from
Mar 28, 2019
Merged

[Filebeat] Cisco ASA module #11171

merged 16 commits into from
Mar 28, 2019

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Mar 8, 2019 •
edited
Loading

Closes #9200

@adriansr adriansr mentioned this pull request Mar 12, 2019
Merged
@adriansr adriansr force-pushed the feature_fb_cisco_asa branch from 79b064d to 4201bd4 Compare March 18, 2019 21:56
@adriansr adriansr marked this pull request as ready for review March 18, 2019 22:39
@adriansr adriansr requested review from a team as code owners March 18, 2019 22:39
@elasticmachine
Copy link
Collaborator

Pinging @elastic/secops

@adriansr adriansr changed the title [Filebeat][WIP] Cisco ASA module [Filebeat] Cisco ASA module Mar 18, 2019
andrewkroh
andrewkroh approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dashboard looks nice. I still have deployed this yet to test it, but test cases look good.

LGTM

@adriansr adriansr force-pushed the feature_fb_cisco_asa branch from d9f138e to a3281e6 Compare March 25, 2019 13:41
andrewkroh
andrewkroh approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There's just a CHANGELOG conflict.

filebeat/docs/modules/cisco.asciidoc
This is a module for Cisco network device's logs. Currently supports the `asa`
fileset for Cisco ASA firewall logs received over syslog or read from a file.

Cisco ASA devices also support exporting flow records using NetFlow, which is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adriansr adriansr force-pushed the feature_fb_cisco_asa branch from a3281e6 to 17765bf Compare March 26, 2019 08:16
@adriansr adriansr merged commit 32eb8d1 into elastic:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
Filebeat Filebeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adriansr @elasticmachine @andrewkroh