Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auditbeat] Socket: Remove ecsDirectionString() #10616

Merged
merged 1 commit into from
Feb 7, 2019
Merged

[Auditbeat] Socket: Remove ecsDirectionString() #10616

merged 1 commit into from
Feb 7, 2019

Conversation

cwurm
Copy link
Contributor

@cwurm cwurm commented Feb 6, 2019 •
edited
Loading

#10339 changed the string values of socket.Direction to be ECS compatible. Auditbeat's socket dataset has a ecsDirectionString() method that does the same. It is now no longer necessary.

@cwurm cwurm requested a review from a team as a code owner February 6, 2019 12:47
@elasticmachine
Copy link
Collaborator

Pinging @elastic/secops

webmat
webmat approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwurm cwurm merged commit 2cc1c32 into elastic:master Feb 7, 2019
@cwurm cwurm deleted the socket_remove_ecsdirectionstring branch February 7, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmat webmat webmat approved these changes

Assignees
No one assigned
Labels
Auditbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwurm @elasticmachine @webmat