Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: exclude vendor folder when calling gofmt and go vet #779

Closed
cyrilleverrier opened this issue Jan 20, 2016 · 0 comments
Closed

Comments

@cyrilleverrier
Copy link
Contributor

Step to reproduce

  1. Write a community beat that uses glide to vendor dependencies
  2. make fmt
  3. make simplify
  4. make vet

Expected Result

The above make commands are performed on the community beat's source code only.

Actual Result

The above make commands are performed on the community beat's source code AND on all the vendors' source code.

@ruflin ruflin closed this as completed in 72eb572 Jan 20, 2016
ruflin added a commit that referenced this issue Jan 20, 2016
Fix #779: libbeat/Makefile filters vendor folder
Keylor42 pushed a commit to amundi/beats that referenced this issue Feb 9, 2016
the FIELDS

updated Notes field when parsing of a Table fails, when no exchange, the field exchange is no longer displayed instead of none, commented the two Timestamp tests that made the Travis build failed

gofmted whole packetbeat code

empty exchange not displayed, connection.close and channel.close are now waiting for a close ok method. if the close ok method never arrives, the transaction is published in the expireTransaction function and the Notes field is updated to indicate it

Create a proper ICMP only BPF filter

Update to golang 1.5.3

Filebeat system tests adapted to new structure

Topbeat system tests updated

Move implementation of packetbeat system tests to new base

Not all code was moved to far, as there are some special implementations in packetbeat

Update winlogbeat to the newest beat system tests

Apply flake8

Fix 769: building the test binary includes all vendor package

"go test -c -covermode=atomic -coverpkg" is called with a list of packages isntead of "./..."

Add PyYAML to Windows vagrant box.

Change system test kill_and_wait method to gracefully stop processes on Windows

Fixes elastic#599

Refactor beat exit

* Introduce Signal function which is called if using CTRL-C or similar
* Run now returns an error and doesn't exist itself anymore
* Fix spooler and crawler shutdown issue
* Update mockbeat to check Run return error.

Thanks to @cyrilleverrier for his contribution here.

Fix elastic#779: libbeat/Makefile filters vendor folder

all the files inside the ./vendor/* folder are now excluded
when executing:
	make fmt
	make simplify
	make vet

Edit new/changed content added to topbeat for 1.1

Minor fix to awkward sentence

move preprocessor from libbeat and move packetbeat

- remove preprocessor worker completely from libbeat
- introduce transaction publisher in packetbeat to event processing:
  - GeoIP
  - normalize addresses
- simplify sync/async publisher client
- update new_protocol docs and changelog

Validate length in parser

Check length in pgsql parser before parsing column content in case column
length > buffer length.

changed results member of amqp struct to publish.Transactions, updated test file

handling of a message splitted in several body frames, need to test it. began to parse connection methods

handling of connection information methods, like connection.start, connection.open or channel.open, added a hide_connection_information in config set to true by default to choose to display them or not

fixed bytes in bytes out for classic methods, added basic qos method in connection information option, channel and connections methods with an error code above or equal to 300 are always published, some new functions are added to see if method reflects an error in the protocol

removed useless condition in expireTransaction

added some pcap tests

added three tests for amqp and their pcap files, corrected the fields.yml and added the amqp part in the packetbeat.yml.j2 for tests

camelcased structs, created parser file

updated the yaml with the last option, removed amqp.response field in the connectionStartOkMethod since it can hold the credentials of the client when a plain auth is selected

fixed yaml, camelcased const, some style fixes in code

added hasProperty function, added verbose in testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant