[Metricbeat] Add tags support on vsphere module

[adelbot]

Hi All,

Vmware commit govmomi to use the "tags".
Like the custom properties, can you add Tags properties in the data ?

vmware/govmomi#1139

Best Regards

[ruflin]

Thanks for keeping an eye on this one. Interested to open a PR with the change? The only issue at the moment probably is that the change is not in a release yet from govmomi?

[adelbot]

The release of govmomi is ok. Yes, I want a PR if it s possible De : Nicolas Ruflin [mailto:notifications@github.com] Envoyé : jeudi 12 juillet 2018 09:05 À : elastic/beats <beats@noreply.github.com> Cc : DELBOT Alain <alain.delbot@laposte.fr>; Author <author@noreply.github.com> Objet : Re: [elastic/beats] Beats : vsphere Module (#7552) Thanks for keeping an eye on this one. Interested to open a PR with the change? The only issue at the moment probably is that the change is not in a release yet from govmomi? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#7552 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AF5FTAwD49kTyCThs0gLwq31AvmSGF0gks5uFvUxgaJpZM4VJAmP>. Post-scriptum La Poste Ce message est confidentiel. Sous reserve de tout accord conclu par ecrit entre vous et La Poste, son contenu ne represente en aucun cas un engagement de la part de La Poste. Toute publication, utilisation ou diffusion, meme partielle, doit etre autorisee prealablement. Si vous n'etes pas destinataire de ce message, merci d'en avertir immediatement l'expediteur.

[ruflin]

The change is is already in the v0.18.0 release? https://github.com/vmware/govmomi/releases/tag/v0.18.0

For the PR: I was more asking if you are interested to open one :-)

[adelbot]

Il use the latest version. For the PR : I really need to have tags / categories with my metrics virtualhost De : Nicolas Ruflin [mailto:notifications@github.com] Envoyé : vendredi 13 juillet 2018 10:09 À : elastic/beats <beats@noreply.github.com> Cc : DELBOT Alain <alain.delbot@laposte.fr>; Author <author@noreply.github.com> Objet : Re: [elastic/beats] Beats : vsphere Module (#7552) The change is is already in the v0.18.0 release? https://github.com/vmware/govmomi/releases/tag/v0.18.0 For the PR: I was more asking if you are interested to open one :-) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#7552 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AF5FTFceu_AGiMf5-B7v1kq-Rn2IRQMjks5uGFWtgaJpZM4VJAmP>. Post-scriptum La Poste Ce message est confidentiel. Sous reserve de tout accord conclu par ecrit entre vous et La Poste, son contenu ne represente en aucun cas un engagement de la part de La Poste. Toute publication, utilisation ou diffusion, meme partielle, doit etre autorisee prealablement. Si vous n'etes pas destinataire de ce message, merci d'en avertir immediatement l'expediteur.

[adelbot]

With the master version of govc govc_linux_amd64 tags.category.ls => StorageType CCX Env ComputeType Owner NetworkZone AntiAffinityGroupID StorageTemperature govc_linux_amd64 tags.association.ls -json /XP/vm/MGMT/WAA/WEYA0130 => [ { "Name": "shared", "TagID": "urn:vmomi:InventoryServiceTag:e9b62a08-ef48-4355-93e5-6f536ae2e097:GLOBAL" }, { "Name": "Production", "TagID": "urn:vmomi:InventoryServiceTag:4a30396a-28ed-463e-b735-ad9d3d7367f3:GLOBAL" }, { "Name": "WAA", "TagID": "urn:vmomi:InventoryServiceTag:32d3660a-170b-440d-b21c-7bf8d557464a:GLOBAL" }, { "Name": "PVGZ373", "TagID": "urn:vmomi:InventoryServiceTag:0c85106a-7886-4c80-bf8c-421ff5d7c5fd:GLOBAL" }, { "Name": "resilient", "TagID": "urn:vmomi:InventoryServiceTag:611adac5-c7a4-4c82-b01e-906027982d83:GLOBAL" } ] De : Nicolas Ruflin [mailto:notifications@github.com] Envoyé : vendredi 13 juillet 2018 10:09 À : elastic/beats <beats@noreply.github.com> Cc : DELBOT Alain <alain.delbot@laposte.fr>; Author <author@noreply.github.com> Objet : Re: [elastic/beats] Beats : vsphere Module (#7552) The change is is already in the v0.18.0 release? https://github.com/vmware/govmomi/releases/tag/v0.18.0 For the PR: I was more asking if you are interested to open one :-) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#7552 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AF5FTFceu_AGiMf5-B7v1kq-Rn2IRQMjks5uGFWtgaJpZM4VJAmP>. Post-scriptum La Poste Ce message est confidentiel. Sous reserve de tout accord conclu par ecrit entre vous et La Poste, son contenu ne represente en aucun cas un engagement de la part de La Poste. Toute publication, utilisation ou diffusion, meme partielle, doit etre autorisee prealablement. Si vous n'etes pas destinataire de ce message, merci d'en avertir immediatement l'expediteur.

[ruflin]

I'm not sure if our modules should rely on a master branch TBH or better use one of the release. Do you have some knowledge on when a next release could come out?

[adelbot]

Hi, no, i haven’t any ideas De : Nicolas Ruflin [mailto:notifications@github.com] Envoyé : lundi 16 juillet 2018 09:55 À : elastic/beats <beats@noreply.github.com> Cc : DELBOT Alain <alain.delbot@laposte.fr>; Author <author@noreply.github.com> Objet : Re: [elastic/beats] Beats : vsphere Module (#7552) I'm not sure if our modules should rely on a master branch TBH or better use one of the release. Do you have some knowledge on when a next release could come out? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#7552 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AF5FTFZOvGVsuw0FEd6j4kPGcxJDuowxks5uHEbXgaJpZM4VJAmP>. Post-scriptum La Poste Ce message est confidentiel. Sous reserve de tout accord conclu par ecrit entre vous et La Poste, son contenu ne represente en aucun cas un engagement de la part de La Poste. Toute publication, utilisation ou diffusion, meme partielle, doit etre autorisee prealablement. Si vous n'etes pas destinataire de ce message, merci d'en avertir immediatement l'expediteur.

[dougm]

Note that the new govmomi tags API is not finalized yet, I've opened an issue to track the status: vmware/govmomi#1180

[ruflin]

@dougm Thanks a lot for the heads up.

[jsoriano]

govmomi 0.19.0 was released 5 days ago, including the support for tags API, we could continue with this if someone is interested to open a PR 🙂

[adelbot]

I m always interested to retrieve all tags attached to each vm or on a list tags

[adelbot]

PR #8918

[MnrGreg]

Tagging would be quite useful to provide rudimentary cost show back through Elastic.

One could create some relatively straight forward dashboards based on ones unit costs for vsphere vCPU, memory and disk- and then slice and dice by VM tags to get a view of costs by environment, application, business units, or whatever tags one happens to have.

+1 for tag retrieval folks!

[botelastic]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[botelastic]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jsoriano]

govmomi is being updated in #26167.

[botelastic]

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!