Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libbeat] Compiling for FreeBSD not working #13400

Closed
andrewkroh opened this issue Aug 29, 2019 · 2 comments · Fixed by #13654
Closed

[libbeat] Compiling for FreeBSD not working #13400

andrewkroh opened this issue Aug 29, 2019 · 2 comments · Fixed by #13654
Labels
bug

Comments

@andrewkroh
Copy link
Member

andrewkroh commented Aug 29, 2019 •
edited
Loading

Some changes were made to Go to support FreeBSD 12 in golang/go#22448 and some of the freebsd syscall APIs changed in an incompatible way with the linux APIs.

One issue this causes is that the vendored Docker library is not compiling for FreeBSD. moby/moby#38818 was a proposed fixed, but not merged.

--> freebsd/amd64 error: exit status 2

Stderr: # github.com/elastic/beats/vendor/github.com/docker/docker/pkg/system

../vendor/github.com/docker/docker/pkg/system/mknod.go:12:19: cannot use dev (type int) as type uint64 in argument to unix.Mknod
@andrewkroh andrewkroh added the bug label Aug 29, 2019
andrewkroh added a commit to andrewkroh/beats that referenced this issue Aug 29, 2019
@andrewkroh
Disable freebsd cross-compile
0ed19b0 
Addresses elastic#13400 until moby/moby fixes the issue and we update our vendor copy.
@andrewkroh andrewkroh mentioned this issue Aug 29, 2019
Merged
@andrewkroh
Copy link
Member Author

I have open #13402 to temporarily disable the FreeBSD cross-compile until moby/moby fixes the issue and we can update our vendor copy.

If it's not fixed soon we could fork moby/moby and fix it ourself.

andrewkroh added a commit that referenced this issue Aug 29, 2019
@andrewkroh
Disable freebsd cross-compile (#13402)
8a53ab3 
Addresses #13400 until moby/moby fixes the issue and we update our vendor copy.
andrewkroh added a commit to andrewkroh/beats that referenced this issue Aug 29, 2019
@andrewkroh
Disable freebsd cross-compile (elastic#13402)
73ac195 
Addresses elastic#13400 until moby/moby fixes the issue and we update our vendor copy.

(cherry picked from commit 8a53ab3)
@andrewkroh andrewkroh mentioned this issue Aug 29, 2019
Merged
andrewkroh added a commit that referenced this issue Aug 29, 2019
@andrewkroh
Disable freebsd cross-compile (#13402) (#13407)
7078712 
Addresses #13400 until moby/moby fixes the issue and we update our vendor copy.

(cherry picked from commit 8a53ab3)
@andrewkroh andrewkroh mentioned this issue Sep 3, 2019
Merged
andrewkroh added a commit to andrewkroh/beats that referenced this issue Sep 12, 2019
@andrewkroh
Fix build tags and add bsd back to x-compile
9f0a243 
The build tags added in elastic#13509 didn't have an effect because only line comments can precede build tags.

This also adds back cross-compilation for freebsd and netbsd that was disabled due to Docker compilation issues. Closes elastic#13400
@andrewkroh andrewkroh mentioned this issue Sep 12, 2019
Merged
@andrewkroh
Copy link
Member Author

Build tags have been added in #13509 so that Docker code is only included in the build when targeting windows, linux, darwin.

andrewkroh added a commit that referenced this issue Sep 12, 2019
@andrewkroh
Fix build tags and add bsd back to x-compile (#13654)
5ada967 
The build tags added in #13509 didn't have an effect because only line comments can precede build tags.

This also adds back cross-compilation for freebsd and netbsd that was disabled due to Docker compilation issues. Closes #13400
@jakommo jakommo mentioned this issue Nov 21, 2019
Open
leweafan pushed a commit to leweafan/beats that referenced this issue Apr 28, 2023
@andrewkroh
Disable freebsd cross-compile (elastic#13402) (elastic#13407)
a5130e4 
Addresses elastic#13400 until moby/moby fixes the issue and we update our vendor copy.

(cherry picked from commit a43f720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix build tags and add bsd back to x-compile andrewkroh/beats
1 participant
@andrewkroh