Skip to content

Commit

Permalink
Only log error (don't also index it) if xpack is enabled. (#12265)
Browse files Browse the repository at this point in the history
* Only log error (don't also index it) if xpack is enabled.

Indexing it would index it into metricbeat-* indices instead of .monitoring-* indices, which are currently not equipped to handle error documents.

* Adding CHANGELOG entry
  • Loading branch information
ycombinator authored May 28, 2019
1 parent b733788 commit 0900e01
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.next.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d
- Fix direction of incoming IPv6 sockets. {pull}12248[12248]
- Validate that kibana/status metricset cannot be used when xpack is enabled. {pull}12264[12264]
- Ignore prometheus metrics when their values are NaN or Inf. {pull}12084[12084] {issue}10849[10849]
- In the kibana/stats metricset, only log error (don't also index it) if xpack is enabled. {pull}12265[12265]

*Packetbeat*

Expand Down
4 changes: 4 additions & 0 deletions metricbeat/module/kibana/stats/stats.go
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,10 @@ func (m *MetricSet) Fetch(r mb.ReporterV2) error {

err := m.fetchStats(r, now)
if err != nil {
if m.XPackEnabled {
m.Logger().Error(err)
return nil
}
return err
}

Expand Down

0 comments on commit 0900e01

Please sign in to comment.