Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OTel Bridge span destination resource pseudo-code #644

Merged
merged 1 commit into from
May 7, 2022

Conversation

trentm
Copy link
Member

@trentm trentm commented May 4, 2022

This updates the pseudo-code for compatibility mapping of span
destination resource from OTel attributes to pass the
otel_bridge.feature gherkin tests. It more closely matches the current
Java APM agent implementation.

checklist

  • Create PR as draft
  • Approval by at least one other agent
  • Mark as Ready for Review (automatically requests reviews from all agents and PM via CODEOWNERS)
    • Remove PM from reviewers if impact on product is negligible
    • Remove agents from reviewers if the change is not relevant for them
  • Merge after 2 business days passed without objections
    To auto-merge the PR, add /schedule YYYY-MM-DD to the PR description.

/schedule 2022-05-07

This updates the pseudo-code for compatibility mapping of span
destination resource from OTel attributes to pass the
otel_bridge.feature gherkin tests. It more closely matches the current
Java APM agent implementation.
@trentm trentm requested a review from SylvainJuge May 4, 2022 22:03
@trentm trentm self-assigned this May 4, 2022
@apmmachine
Copy link

apmmachine commented May 4, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-06T04:59:00.371+0000

  • Duration: 3 min 42 sec

Copy link
Member

@SylvainJuge SylvainJuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching & fixing this @trentm !

basepi added a commit to basepi/apm-agent-python that referenced this pull request May 5, 2022
basepi added a commit to basepi/apm-agent-python that referenced this pull request May 5, 2022
@trentm trentm marked this pull request as ready for review May 5, 2022 15:00
@trentm trentm requested review from a team as code owners May 5, 2022 15:00
@trentm trentm removed request for a team May 5, 2022 15:01
@trentm
Copy link
Member Author

trentm commented May 5, 2022

@gregkalapos I haven't looked at the .NET OTel Bridge implementation (elastic/apm-agent-dotnet#1498). Do you know if it would need to update for this pseudo-code change?

basepi added a commit to elastic/apm-agent-python that referenced this pull request May 5, 2022
@SylvainJuge
Copy link
Member

@gregkalapos I haven't looked at the .NET OTel Bridge implementation (elastic/apm-agent-dotnet#1498). Do you know if it would need to update for this pseudo-code change?

I think that the dotnet implementation relies on gherkin specs, so if the spec tests are applied it should already be OK.

@github-actions github-actions bot merged commit b71c6a7 into main May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants