-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OTel Bridge span destination resource pseudo-code #644
Conversation
This updates the pseudo-code for compatibility mapping of span destination resource from OTel attributes to pass the otel_bridge.feature gherkin tests. It more closely matches the current Java APM agent implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching & fixing this @trentm !
@gregkalapos I haven't looked at the .NET OTel Bridge implementation (elastic/apm-agent-dotnet#1498). Do you know if it would need to update for this pseudo-code change? |
I think that the dotnet implementation relies on gherkin specs, so if the spec tests are applied it should already be OK. |
This updates the pseudo-code for compatibility mapping of span
destination resource from OTel attributes to pass the
otel_bridge.feature gherkin tests. It more closely matches the current
Java APM agent implementation.
checklist
CODEOWNERS
)To auto-merge the PR, add
/
schedule YYYY-MM-DD
to the PR description./schedule 2022-05-07