Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure ES index names are lowercase for ILM #4322

Merged
merged 2 commits into from
Oct 15, 2020

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Oct 15, 2020

Motivation/summary

Ensure ILM custom index suffixes are lowercased to ensure templates and indices in ES can be created.

Checklist

- [ ] I have signed the Contributor License Agreement.

I have considered changes for:
- [ ] documentation
- [ ] logging (add log lines, choose appropriate log selector, etc.)
- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)

How to test these changes

configure APM Server to setup ILM with index-suffixes that are uppercase, start APM Server and ensure templates and indices are created with the index-suffix lowercased.

Related issues

fixes #4321

Ensure ILM custom index suffixes are also lowercased.

fixes elastic#4294
@codecov-io
Copy link

Codecov Report

Merging #4322 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4322   +/-   ##
=======================================
  Coverage   79.67%   79.67%           
=======================================
  Files         161      162    +1     
  Lines        8983     8994   +11     
=======================================
+ Hits         7157     7166    +9     
- Misses       1826     1828    +2     
Impacted Files Coverage Δ
idxmgmt/ilm/config.go 82.40% <100.00%> (ø)
log/ratelimit.go 100.00% <100.00%> (ø)
model/modeldecoder/rumv3/decoder.go 94.97% <100.00%> (ø)
model/modeldecoder/v2/decoder.go 95.90% <100.00%> (+0.01%) ⬆️
...ack/apm-server/aggregation/txmetrics/aggregator.go 92.08% <100.00%> (+0.20%) ⬆️
beater/jaeger/common.go 75.00% <0.00%> (-7.15%) ⬇️

@apmmachine
Copy link
Contributor

apmmachine commented Oct 15, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #4322 updated]

  • Start Time: 2020-10-15T10:19:57.429+0000

  • Duration: 44 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 4293
Skipped 145
Total 4438

Steps errors 3

Expand to view the steps failures

  • Name: Run Window tests

    • Description:

    • Duration: 9 min 25 sec

    • Start Time: 2020-10-15T10:37:37.364+0000

    • log

  • Name: Compress

    • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage

    • Duration: 0 min 0 sec

    • Start Time: 2020-10-15T10:36:14.471+0000

    • log

  • Name: Compress

    • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests

    • Duration: 0 min 0 sec

    • Start Time: 2020-10-15T10:48:13.253+0000

    • log

@simitt simitt merged commit 24ece94 into elastic:master Oct 15, 2020
simitt added a commit to simitt/apm-server that referenced this pull request Oct 15, 2020
Ensure ILM custom index suffixes are also lowercased.

fixes elastic#4321
simitt added a commit to simitt/apm-server that referenced this pull request Oct 15, 2020
Ensure ILM custom index suffixes are also lowercased.

fixes elastic#4321
simitt added a commit to simitt/apm-server that referenced this pull request Oct 15, 2020
Ensure ILM custom index suffixes are also lowercased.

fixes elastic#4321
simitt added a commit that referenced this pull request Oct 15, 2020
Ensure ILM custom index suffixes are also lowercased.

fixes #4321
simitt added a commit that referenced this pull request Oct 15, 2020
Ensure ILM custom index suffixes are also lowercased.

fixes #4321
simitt added a commit that referenced this pull request Oct 15, 2020
Ensure ILM custom index suffixes are also lowercased.

fixes #4321
@simitt simitt deleted the lowercase-ilm-suffix branch October 19, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uppercase index_suffix leads to a failure to create index template
4 participants