Add support for go packages with explicit versions (#1764)

elastic · Jul 6, 2022 · 53368eb · 53368eb
1 parent 1ac3086
commit 53368eb
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 2 deletions.
diff --git a/src/test/groovy/WithGoEnvUnixStepTests.groovy b/src/test/groovy/WithGoEnvUnixStepTests.groovy
@@ -171,6 +171,20 @@ class WithGoEnvUnixStepTests extends ApmBasePipelineTest {
     assertJobStatusSuccess()
   }
 
+  @Test
+  void testPkgs_with_version() throws Exception {
+    helper.registerAllowedMethod('nodeOS', [], { "linux" })
+    def isOK = false
+    script.call(version: "1.16.1", pkgs: [ "P1@1", "P2@2" ]){
+      isOK = true
+    }
+    printCallStack()
+    assertTrue(isOK)
+    assertTrue(assertMethodCallContainsPattern('sh', 'go install P1@1'))
+    assertTrue(assertMethodCallContainsPattern('sh', 'go install P2@2'))
+    assertJobStatusSuccess()
+  }
+
   @Test
   void testDefaultGoVersion() throws Exception {
     helper.registerAllowedMethod('nodeOS', [], { "linux" })

diff --git a/src/test/groovy/WithGoEnvWindowsStepTests.groovy b/src/test/groovy/WithGoEnvWindowsStepTests.groovy
@@ -119,6 +119,19 @@ void testOSArg() throws Exception {
     assertJobStatusSuccess()
   }
 
+  @Test
+  void testPkgs_with_version() throws Exception {
+    def isOK = false
+    script.call(version: "1.16.1", pkgs: [ "P1@1", "P2@2" ]){
+      isOK = definedVariables('1.16.1', 'windows')
+    }
+    printCallStack()
+    assertTrue(isOK)
+    assertTrue(assertMethodCallContainsPattern('bat', 'go install P1@1'))
+    assertTrue(assertMethodCallContainsPattern('bat', 'go install P2@2'))
+    assertJobStatusSuccess()
+  }
+
   @Test
   void testDefaultGoVersion() throws Exception {
     helper.registerAllowedMethod('nodeOS', [], { "windows" })

diff --git a/vars/withGoEnvUnix.groovy b/vars/withGoEnvUnix.groovy
@@ -73,8 +73,13 @@ def installPackages(Map args = [:]) {
   def atVersion = isBeforeGo1_16(version: version) ? '' : "@latest"
   withEnv(["GOARCH=${arch}"]){
     args.pkgs?.each{ p ->
+      // If the package is already with the given version then use it
+      def packageWithVersion = "${p}${atVersion}"
+      if (p.contains('@')) {
+        packageWithVersion = "${p}"
+      }
       retryWithSleep(retries: 3, seconds: 5, backoff: true){
-        sh(label: "Installing ${p}", script: "go ${method} ${p}${atVersion}")
+        sh(label: "Installing ${packageWithVersion}", script: "go ${method} ${packageWithVersion}")
       }
     }
   }

diff --git a/vars/withGoEnvWindows.groovy b/vars/withGoEnvWindows.groovy
@@ -63,8 +63,13 @@ def call(Map args = [:], Closure body) {
       bat(label: "Installing Go ${version}", script: content)
     }
     pkgs?.each{ p ->
+      // If the package is already with the given version then use it
+      def packageWithVersion = "${p}${atVersion}"
+      if (p.contains('@')) {
+        packageWithVersion = "${p}"
+      }
       retryWithSleep(retries: 3, seconds: 5, backoff: true){
-        bat(label: "Installing ${p}", script: "go ${method} ${p}${atVersion}")
+        bat(label: "Installing ${packageWithVersion}", script: "go ${method} ${packageWithVersion}")
       }
     }
     body()