Skip to content

Commit

Permalink
ci(jenkins): delegate docker setup to the preCommit step (#557)
Browse files Browse the repository at this point in the history
  • Loading branch information
v1v authored Aug 14, 2019
1 parent 63ce779 commit b4fc446
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
6 changes: 2 additions & 4 deletions .ci/Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,8 @@ pipeline {
deleteDir()
unstash 'source'
script {
docker.image('python:3.7-stretch').inside("-e PATH=${PATH}:${env.WORKSPACE}/bin"){
dir("${BASE_DIR}"){
preCommit(commit: "${GIT_BASE_COMMIT}", junit: true)
}
dir(BASE_DIR){
preCommit(commit: "${GIT_BASE_COMMIT}", junit: true, dockerImage: 'python:3.7-stretch')
}
}
}
Expand Down
4 changes: 1 addition & 3 deletions .ci/linting.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ pipeline {
steps {
script {
def sha = getGitCommitSha()
docker.image('python:3.7-stretch').inside("-e PATH=${PATH}:${env.WORKSPACE}/bin"){
preCommit(commit: "${sha}", junit: true)
}
preCommit(commit: "${sha}", junit: true, dockerImage: 'python:3.7-stretch')
}
}
}
Expand Down

0 comments on commit b4fc446

Please sign in to comment.