Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump tape from 5.7.5 to 5.8.1 #4091

Merged
merged 7 commits into from
Jul 8, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 17, 2024

Bumps tape from 5.7.5 to 5.8.1.

Changelog

Sourced from tape's changelog.

v5.8.1 - 2024-06-16

Fixed

Commits

  • [Fix] assertion: pass through assertion return value, for promises 2ad86d4

v5.8.0 - 2024-06-14

Fixed

Commits

  • [meta] update URLs 77cabeb
  • [New] allow TODO tests to be "ok" with env var TODO_IS_OK 6cd06f5
  • [Tests] strip node’s deprecation warnings 8d40837
  • [Tests] increase coverage aa7de58
  • [Refactor] Test: minor tweaks ce4ce8a
  • [meta] simplify exports d39cb8d
  • [Deps] update @ljharb/resumer, @ljharb/through, hasown 77952d0
  • [Tests] handle more stack trace variation in Node v0.8 d2f0778
  • [Deps] update array.prototype.every, string.prototype.trim 732268b
  • [Dev Deps] update @ljharb/eslint-config 7b39e14
  • [Refactor] test: reduce binding by using polyfill entrypoints 91a83b6
  • [Dev Deps] remove unused intl-fallback-symbol, is-core-module eafacf6
  • [Deps] update object-is 1b01656
  • [meta] simplify exports f9eac5b
Commits
  • e52bb18 v5.8.1
  • 7c84990 [meta] fix URLs
  • 2ad86d4 [Fix] assertion: pass through assertion return value, for promises
  • 998d9cd v5.8.0
  • d2f0778 [Tests] handle more stack trace variation in Node v0.8
  • 7ba18ac [New] add t.assertion
  • 7b39e14 [Dev Deps] update @ljharb/eslint-config
  • 8d40837 [Tests] strip node’s deprecation warnings
  • 732268b [Deps] update array.prototype.every, string.prototype.trim
  • aa7de58 [Tests] increase coverage
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [tape](https://github.com/tape-testing/tape) from 5.7.5 to 5.8.1.
- [Changelog](https://github.com/tape-testing/tape/blob/master/CHANGELOG.md)
- [Commits](tape-testing/tape@v5.7.5...v5.8.1)

---
updated-dependencies:
- dependency-name: tape
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 17, 2024
@dependabot dependabot bot requested a review from a team June 17, 2024 00:39
Copy link
Member

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav

Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav @hapi/hapi

Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav @hapi/hapi

@trentm
Copy link
Member

trentm commented Jul 8, 2024

I think that last commit confirms that, at least for the @hapi/hapi TAV tests, the issue is IPv6 vs IPv4: client and server both using "localhost", one gets ipv6, one gets ipv4 ... failure.

From https://github.com/elastic/apm-agent-nodejs/actions/runs/9844953164/job/27179445180?pr=4091

The client is using 127.0.0.1:

node_tests-1  | -- required packages ["@hapi/hapi@21.3.10"]
node_tests-1  | -- installing ["@hapi/hapi@21.3.10"]
node_tests-1  | -- running test "node test/instrumentation/modules/hapi/hapi.test.js" with @hapi/hapi (env: {})
node_tests-1  | node:events:498
node_tests-1  |       throw er; // Unhandled 'error' event
node_tests-1  |       ^
node_tests-1  | 
node_tests-1  | Error: connect ECONNREFUSED 127.0.0.1:42067
node_tests-1  |     at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1607:16)
node_tests-1  | Emitted 'error' event on ClientRequest instance at:
node_tests-1  |     at Socket.socketErrorListener (node:_http_client:502:9)
node_tests-1  |     at Socket.emit (node:events:520:28)
node_tests-1  |     at emitErrorNT (node:internal/streams/destroy:170:8)
node_tests-1  |     at emitErrorCloseNT (node:internal/streams/destroy:129:3)
node_tests-1  |     at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
node_tests-1  |   errno: -111,
node_tests-1  |   code: 'ECONNREFUSED',
node_tests-1  |   syscall: 'connect',
node_tests-1  |   address: '127.0.0.1',
node_tests-1  |   port: 42067
node_tests-1  | }

The server is listening on ::1:

 node_tests-1  | XXX server.start'ed: server.info= {
node_tests-1  |   created: 1720463218632,
node_tests-1  |   started: 1720463218645,
node_tests-1  |   host: 'localhost',
node_tests-1  |   port: 42067,
node_tests-1  |   protocol: 'http',
node_tests-1  |   id: '09847dc63ad9:189:lydbdnm0',
node_tests-1  |   uri: 'http://localhost:42067',
node_tests-1  |   address: '::1'
node_tests-1  | }

Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav @hapi/hapi

Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav @hapi/hapi,@opentelemetry/api,next

@trentm
Copy link
Member

trentm commented Jul 8, 2024

I think that last commit confirms that, at least for the @hapi/hapi TAV tests, the issue is IPv6 vs IPv4

Sigh. This had already been fixed a few weeks back in #4085. I hadn't noticed that this dependabot PR was from weeks ago.

Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav

@trentm trentm requested a review from david-luna July 8, 2024 19:35
@trentm
Copy link
Member

trentm commented Jul 8, 2024

@david-luna You can approve (and merge if you like) this sometime. I added commits to test things on it, so now I cannot give the approving review.

@trentm trentm merged commit ebe2cd1 into main Jul 8, 2024
197 checks passed
@trentm trentm deleted the dependabot/npm_and_yarn/tape-5.8.1 branch July 8, 2024 21:58
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants