Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: bump threshold to avoid spurious failure for possibly slow CI #3225

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

trentm
Copy link
Member

@trentm trentm commented Mar 29, 2023

This failed in GH Actions CI:
not ok 16 captureError is fast (<5ms): 6.238244ms

This failed in GH Actions CI:
    not ok 16 captureError is fast (<5ms): 6.238244ms
@trentm trentm self-assigned this Mar 29, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Mar 29, 2023
@trentm
Copy link
Member Author

trentm commented Mar 29, 2023

This had failed in https://github.com/elastic/apm-agent-nodejs/actions/runs/4552294468/jobs/8027446510

        node_tests_1     | ok 15 apm.captureError still calls back with an error id: d563b7ab8fcfa95ee523347fb13acce4
        node_tests_1     | not ok 16 captureError is fast (<5ms): 6.238244ms
        node_tests_1     |   ---
        node_tests_1     |     operator: ok
        node_tests_1     |     expected: true
        node_tests_1     |     actual:   false
        node_tests_1     |     at: <anonymous> (/app/test/context-propagation-only.test.js:195:9)
        node_tests_1     |     stack: |-
        node_tests_1     |       Error: captureError is fast (<5ms): 6.238244ms

@apmmachine
Copy link
Contributor

apmmachine commented Mar 29, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-03-29T20:57:22.290+0000

  • Duration: 21 min 44 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm trentm merged commit 4a0f096 into main Mar 29, 2023
@trentm trentm deleted the trentm/spuriouscontext-propagation-only-timeout-test branch March 29, 2023 22:02
v1v added a commit that referenced this pull request Mar 30, 2023
* upstream/main:
  test: bump threshold to avoid spurious failure for possibly slow CI (#3225)
  test: workaround spurious test failures in http2 tests with node v8 (#3226)
PeterEinberger pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
…lastic#3225)

This failed in GH Actions CI:
    not ok 16 captureError is fast (<5ms): 6.238244ms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants