[META 321] Add log_level spec

[basepi]

Implementing elastic/apm#332

Note that the implementation of this spec also includes adding the option to Kibana.

[trentm]

That commit doesn't fully resolve this ticket: the kibana.git config update remains.
Rhetorical Qs: Why does GitHub thinks this closes the ticket? Is that implicit in having added this issue to "Linked issues" for the PR?

[basepi]

@trentm I've only ever linked issues by mentioning them. Perhaps if you add them in the sidebar it assumes you want to close them when the PR is merged.

If I just want to like them without automatic closing, I do:

Refs #1826

If I want the issue to close when the PR is merged, I do:

Closes #1826

(There are a few keywords that will result in a closed issue: fix, fixes, close, closes, resolves to name a few)

[trentm]

@basepi Thanks. Yah, I've been using "Fixes: #NNN" in the commit message to close.

From https://docs.github.com/en/free-pro-team@latest/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue

When you merge a linked pull request into the default branch of a repository, its linked issue is automatically closed.

So I think I'll stick to just using the commit message/initial PR description, and I'll try to pick up using "Refs ..." syntax.

[basepi]

Yeah as long as you stay away from any of those close keywords, you should be fine.

[trentm]

elastic/kibana#85346 is for the Kibana related change.

[trentm]

Kibana master: elastic/kibana#85346
Kibana 7.x backport: elastic/kibana#85460

[trentm]

Those are merged now.