Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch all exceptions thrown inside an advice #351

Closed
felixbarny opened this issue Nov 26, 2018 · 1 comment · Fixed by #380
Closed

Catch all exceptions thrown inside an advice #351

felixbarny opened this issue Nov 26, 2018 · 1 comment · Fixed by #380
Assignees
@felixbarny

Comments

@felixbarny
Copy link
Member

If there is a programming error like an NPE or some other RuntimeException or even a ClassNotFoundException/ NoClassDefFoundError because of a missing OSGi bootdelegation, the application itself should not crash.

Instead, the exception should be caught and logged.
@eyalkoren
Copy link
Contributor

An example to why this is super-important - #371

felixbarny added a commit to felixbarny/apm-agent-java that referenced this issue Dec 10, 2018
@felixbarny
Cach all exceptions in advices
75564c5 
closes elastic#351
@felixbarny felixbarny mentioned this issue Dec 10, 2018
Merged
felixbarny added a commit that referenced this issue Dec 11, 2018
@felixbarny
Cach all exceptions in advices (#380)
e7008f0 
closes #351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felixbarny felixbarny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cach all exceptions in advices felixbarny/apm-agent-java
3 participants
@felixbarny @alvarolobato @eyalkoren