Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal package upgrade #1600

Closed
wants to merge 3 commits into from

Conversation

kaanyalti
Copy link

@kaanyalti kaanyalti commented Apr 5, 2024

Upgrading go-sysinfo package

@kaanyalti kaanyalti requested a review from a team as a code owner April 5, 2024 17:39
@kruskall
Copy link
Member

kruskall commented Apr 5, 2024

Hi @kaanyalti

the go agent is using go-sysinfo v1.7.1 which has no dependency on docker so it is not affected.

If you still want to get this merged in and bump the dependency could you rename the PR/commit title and fix the CI failure ?

@kaanyalti
Copy link
Author

kaanyalti commented Apr 5, 2024

Hi @kaanyalti

the go agent is using go-sysinfo v1.7.1 which has no dependency on docker so it is not affected.

If you still want to get this merged in and bump the dependency could you rename the PR/commit title and fix the CI failure ?

@kruskall I'm trying to fix the ci issues right now. I didn't realize that go-sysinfo 1.7.1 has no dependency on the docker package. I was mainly trying to go through the listed vulnerable dependencies in the snyk report. Although looking at it now, I may not have to do a more granular update, specifically update the apmhttp dependencies. Will convert this PR to a draft, and will resolve the issues first.

@kaanyalti kaanyalti marked this pull request as draft April 5, 2024 20:49
@kaanyalti kaanyalti changed the title fix(3034): upgraded go-sysinfo to fix docker security vulnerability Package upgrades Apr 8, 2024
@kaanyalti kaanyalti changed the title Package upgrades Internal package upgrade Apr 8, 2024
@kaanyalti kaanyalti force-pushed the fix-3034/upgrade-go-sysinfo branch from c8b9757 to 701b5d3 Compare April 8, 2024 15:33
@kaanyalti kaanyalti closed this Apr 8, 2024
@kaanyalti kaanyalti deleted the fix-3034/upgrade-go-sysinfo branch April 8, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants