-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update editorconfig naming rules #1295
Conversation
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
@stevejgordon Would you mind taking a look at these rules? They're largely inspired by Roslyn's editorconfig rules and specifically address a few things like:
|
.editorconfig
Outdated
@@ -147,3 +211,6 @@ insert_final_newline=true | |||
|
|||
[*.sh] | |||
end_of_line = lf | |||
|
|||
[{LICENSE,NOTICE}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split out into separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As dicsussed, will open a separate PR.
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Steps errors
Expand to view the steps failures
|
Relates: elastic/apm-agent-dotnet#1295 (cherry picked from commit d5bb92e)
Relates: elastic/apm-agent-dotnet#1295 (cherry picked from commit d5bb92e) Co-authored-by: Russ Cam <russ.cam@elastic.co>
Relates: #1288
/cc @stevejgordon