-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Error exception cause #1277
Conversation
This commit implements the cause property on the exception of an APM error. Cause can capture chained exceptions, which are the chain of inner exceptions for .NET. Closes elastic#1267
This commit avoids the allocation of an array and copying of stacktrace framew when a stacktrace limit > 0 is specified.
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures> Show only the first 10 test failures
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Failing tests pass locally and are failing on other PRs, so it looks like there's a general issue with them on CI. #1272 is open for SQL server integration tests and I've opened https://github.com/elastic/apm-agent-dotnet/issues/1281 for ASP.NET Full Framework tests. Merging this in |
This commit fixes a bug introduced in elastic#1277
This commit fixes a bug introduced in #1277
This commit implements the cause property on the exception of an APM error. Cause can capture chained exceptions, which are the chain of inner exceptions for .NET.
Avoid array allocation and copying of frames when stacktrace limit is greater than 0.
Closes #1267