-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access Request.InputStream only when SOAP header present #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where accessing the Request.InputStream causes the entrie request to be buffered in memory. This has two repercussions: 1. For many large requests, it can potentially cause out of memory 2. It can interfere with a custom IHostBufferPolicySelector used in web API to determine whether to buffer the input stream. With this fix, the input stream is accessed only when a SOAP content-type is present and has not already been read bufferless. Fixes elastic#1113
This was referenced Jan 11, 2021
Looks good, thanks for the quick turnaround time. |
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
|
gregkalapos
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where accessing the
Request.InputStream
causes the entire request to be buffered in memory. This hastwo repercussions:
IHostBufferPolicySelector
used in web API to determine whether to buffer the input stream.With this fix, the input stream is accessed only when a SOAP content-type is present and has not already been read bufferless.
Fixes #1113