Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[META 321] Add log_level spec #970

Closed
basepi opened this issue Oct 5, 2020 · 0 comments · Fixed by #1096
Closed

[META 321] Add log_level spec #970

basepi opened this issue Oct 5, 2020 · 0 comments · Fixed by #1096
Labels
agent-dotnet cross APM agents
Milestone
7.11

Comments

@basepi
Copy link

basepi commented Oct 5, 2020 •
edited by AlexanderWert
Loading

Implementing elastic/apm#332

Note that the implementation of this spec also includes adding the option to Kibana.
@basepi basepi mentioned this issue Oct 5, 2020
Merged
@AlexanderWert AlexanderWert added this to the 7.11 milestone Nov 12, 2020
@AlexanderWert AlexanderWert changed the title Add log_level spec [META 321] Add log_level spec Nov 25, 2020
@AlexanderWert AlexanderWert mentioned this issue Nov 25, 2020
Closed
russcam added a commit to russcam/apm-agent-dotnet that referenced this issue Dec 18, 2020
@russcam
Update log level based on central configuration
acb5027 
This commit updates the log level of the configured
IApmLogger based on the log level received from
central configuration.

An ILogLevelSwitchable interface is introduced that
can be implemented by an IApmLogger to allow
the log level to be updated by central configuration.

ConsoleLogger implements ILogLevelSwitchable
but NetCoreLogger does not. The ability to change
the log level of NetCoreLogger at runtime is controlled
by the provider used with Microsoft.Extensions.Logging.

Closes elastic#970
@russcam russcam mentioned this issue Dec 18, 2020
Merged
russcam added a commit that referenced this issue Dec 22, 2020
@russcam
Update log level based on central configuration and support "off" con…
cddc93d 
…figuration (#1096)

This commit updates the log level of the configured
IApmLogger based on the log level received from
central configuration.

An ILogLevelSwitchable interface is introduced that
can be implemented by an IApmLogger to allow
the log level to be updated by central configuration.

ConsoleLogger implements ILogLevelSwitchable
but NetCoreLogger does not. The ability to change
the log level of NetCoreLogger at runtime is controlled
by the provider used with Microsoft.Extensions.Logging.

Closes #970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-dotnet cross APM agents
Projects
None yet
Milestone
7.11
2 participants
@basepi @AlexanderWert