Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HostBuilderExtensions.UseElasticApm doesn't register DiagnosticsSubscribers #1059

Closed
gregkalapos opened this issue Nov 20, 2020 · 0 comments · Fixed by #1060
Closed

HostBuilderExtensions.UseElasticApm doesn't register DiagnosticsSubscribers #1059

gregkalapos opened this issue Nov 20, 2020 · 0 comments · Fixed by #1060
Assignees
@gregkalapos
Labels
agent-dotnet bug Something isn't working

Comments

@gregkalapos
Copy link
Contributor

gregkalapos commented Nov 20, 2020 •
edited by zube bot
Loading

No description provided.

@gregkalapos gregkalapos added the bug Something isn't working label Nov 20, 2020
@gregkalapos gregkalapos self-assigned this Nov 20, 2020
@gregkalapos gregkalapos changed the title HostBuilderExtensions.UseElasticApm doesn't register DiagnosticsSubscribera HostBuilderExtensions.UseElasticApm doesn't register DiagnosticsSubscribers Nov 20, 2020
@gregkalapos gregkalapos mentioned this issue Nov 23, 2020
Merged
gregkalapos added a commit that referenced this issue Nov 24, 2020
@gregkalapos
HostBuilderExtensions.UseElasticApm: subscribe to subscribers params (
997d924 
#1060)

* HostBuilderExtensions.UseElasticApm: subscribe to `subscribers` parameter

Fixes #1059

* Update HostBuilderExtensionTests.cs

Add test to cover `enabled=false` case.

* Update HostBuilderExtensions.cs

Resolve AgentComponents only once.

* Update HostBuilderExtensions.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregkalapos gregkalapos

Labels
agent-dotnet bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

HostBuilderExtensions.UseElasticApm: subscribe to subscribers params
1 participant
@gregkalapos