Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up CI for master #1068

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Conversation

LukasKalbertodt
Copy link
Member

See commits. Should make things faster...

The assumption was that creating the binary takes forever and thus
even completely rebuilding the debug build for testing is faster. I
tested this locally and it seems not to be the case.
`cargo build --tests --release` after `cargo build --release` is quite
fast. Let's hope this is also true for CI.
@LukasKalbertodt LukasKalbertodt added area:ci Continuous Integration changelog:nope Not worth mentioning in the changelog labels Jan 10, 2024
Otherwise it might build the debug binary (again).
This should get rid of the last source of building Tobira again in CI.
@LukasKalbertodt LukasKalbertodt marked this pull request as ready for review January 10, 2024 13:11
@github-actions github-actions bot temporarily deployed to test-deployment-pr1068 January 10, 2024 13:11 Destroyed
Copy link
Member

@owi92 owi92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a great qol improvement 👌

@owi92 owi92 merged commit abe22ec into elan-ev:master Jan 10, 2024
2 checks passed
@LukasKalbertodt LukasKalbertodt deleted the speed-up-master-ci branch January 10, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci Continuous Integration changelog:nope Not worth mentioning in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants