Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config sync.{user,password} to opencast.* #1219

Closed
LukasKalbertodt opened this issue Aug 7, 2024 · 4 comments · Fixed by #1296
Closed

Move config sync.{user,password} to opencast.* #1219

LukasKalbertodt opened this issue Aug 7, 2024 · 4 comments · Fixed by #1296
Labels
changelog:breaking Breaking changes next-breaking-change Things that should be released with the next breaking-change release
Milestone

Comments

@LukasKalbertodt
Copy link
Member

LukasKalbertodt commented Aug 7, 2024

The sync user+password is by now also used for other purposes, like talking to the external API to delete events. So having them in the sync section is not really useful. This will be a breaking change, so I would like to include it in a release that has a breaking change anyway.

Or... add multiple credentials? Like, use different ones for external API and sync for example?

@LukasKalbertodt LukasKalbertodt added the changelog:breaking Breaking changes label Aug 7, 2024
@LukasKalbertodt LukasKalbertodt added the next-breaking-change Things that should be released with the next breaking-change release label Nov 4, 2024
@LukasKalbertodt LukasKalbertodt added this to the v3.0 milestone Nov 13, 2024
@owi92
Copy link
Member

owi92 commented Dec 2, 2024

Or... add multiple credentials? Like, use different ones for external API and sync for example?

I would prefer to use the same credentials for both sync and other external API stuff, mainly to keep things simple. Is there a practical reason for splitting these?

@LukasKalbertodt
Copy link
Member Author

To be honest: I don't know. We got surprised before by needing to use a special hosts for external API for example. Maybe there are reasons why people want to use different credentials? I suppose it makes not sense for security, because both users need ROLE_ADMIN anyway. Might be worth asking in the technical meeting once? Or not ignoring my remark for which I had no concrete basis anyway 🤷

@owi92
Copy link
Member

owi92 commented Dec 9, 2024

I did not ask in the technical meeting, but yeah, should be fine I think.

@LukasKalbertodt LukasKalbertodt linked a pull request Dec 9, 2024 that will close this issue
LukasKalbertodt added a commit that referenced this issue Dec 10, 2024
@LukasKalbertodt
Copy link
Member Author

done in #1296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:breaking Breaking changes next-breaking-change Things that should be released with the next breaking-change release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants