Skip to content

Commit

Permalink
Change icon for slide text match tooltip to letter-text
Browse files Browse the repository at this point in the history
Unfortunately, this required adding a new package. `react-icons` has
a super old version of lucide icons, even in its newest version. Since
almost all of our icons are from Lucide anyway, it makes sense to just
use their packages directly.
  • Loading branch information
LukasKalbertodt committed Sep 9, 2024
1 parent 55a892c commit 30b3363
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
9 changes: 9 additions & 0 deletions frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
"hls.js": "^1.5.7",
"i18next": "^23.10.0",
"i18next-browser-languagedetector": "^7.2.0",
"lucide-react": "^0.439.0",
"paella-basic-plugins": "1.44.10",
"paella-core": "1.49.3",
"paella-mp4multiquality-plugin": "1.47.1",
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/routes/Search.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ import { Trans, useTranslation } from "react-i18next";
import { graphql, PreloadedQuery, usePreloadedQuery, useQueryLoader } from "react-relay";
import {
LuCalendarRange,
LuImage,
LuLayout,
LuLibrary,
LuPlayCircle,
LuRadio,
LuVolume2,
LuX,
} from "react-icons/lu";
import { LetterText } from "lucide-react";
import { IconType } from "react-icons";
import { ReactNode, RefObject, useEffect, useRef } from "react";
import {
Expand Down Expand Up @@ -730,7 +730,7 @@ const TextMatchTooltip: React.FC<TextMatchTooltipProps> = ({ previewImage, textM
}}>
{match(textMatch.ty, {
CAPTION: () => <LuVolume2 />,
SLIDE_TEXT: () => <LuImage />,
SLIDE_TEXT: () => <LetterText />,
"%future added value": unreachable,
})}
</div>
Expand Down

0 comments on commit 30b3363

Please sign in to comment.