Add hide_key query parameter #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cgsdev0
commented
Sep 5, 2024
| @@ -134,6 +134,11 @@ | |||
| encrypt = await Encrypt.new(key); | |||
| const encryptedZeros = await encrypt.zeros(); | |||
|
|
|||
| const searchParams = new URLSearchParams(window.location.search); | |||
| if (searchParams.get("hide_key") === "true") { | |||
| window.location.hash = ""; | |||
There was a problem hiding this comment.
note: this will break if onMount runs more than once here
i'm operating under the assumption that it only happens once; would appreciate insight
|
Hi @cgsdev0 -- if you are editing the URL bar, does it make sense to just edit out the URL? |
maybe I'm wrong (traveling atm so I can't test), but I think manual edits to the URL bar are not very persistent. like if i switch to another tab and come back, does the edit stay? also refreshing would bring it back it's also very possible i'm over thinking this |
|
hmm it does seem to persist more than I thought, maybe that will work good enough thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related discussion: #65 (comment)
I haven't tested this change yet, but this is roughly what I am proposing.