-
-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tracing colors cannot be suppressed #65
Comments
I'm glad it's working well for you! That's awesome :) I didn't realize that tracing-subscriber had no way to turn off colors via environment variable. Sounds like the upstream issue has some activity so I think we could wait and see, and I'm happy to publish a release of bore when tracing is updated. |
This update adds support for the NO_COLOR environment variable in tracing output, which allows suppressing ANSI color codes in log output. This is particularly useful when running bore as a Windows service. Fixes ekzhang#65
I had Devin investigate this and seems like it's now fixed upstream. It tested the version upgrade locally and I created a PR (#146): https://preview.devin.ai/sessions/2b78db994f0848bfbd2b181fc33dc044 |
This update adds support for the NO_COLOR environment variable in tracing output, which allows suppressing ANSI color codes in log output. This is particularly useful when running bore as a Windows service. Fixes #65 Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
I am running bore to expose local ports to a remote Windows server and it works quite well, thank you!
The only annoyance I have noticed that log/tracing colors do not seem to be able to be turned off, which make the log files look funny when for example wrapping bore in WinSW (for running as a Windows service).
I tried
NO_COLOR
, that only affects the help colors; but that does not affect tracing: tokio-rs/tracing#2388.Opening this issue to make you aware of that so it could be fixed when there is a fix in tokio tracing. :)
The text was updated successfully, but these errors were encountered: