Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v prefix to eksctl tags #3241

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Add v prefix to eksctl tags #3241

merged 1 commit into from
Feb 9, 2021

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Feb 9, 2021 •
edited
Loading

Description

Because go is special and requires special tags
Part of #813

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@michaelbeaumont michaelbeaumont added area/build-and-release skip-release-notes Causes PR not to show in release notes labels Feb 9, 2021
@michaelbeaumont michaelbeaumont requested a review from a team February 9, 2021 13:25
@weaveworksbot weaveworksbot merged commit 3940689 into eksctl-io:main Feb 9, 2021
@michaelbeaumont michaelbeaumont deleted the v_prefix_tags branch February 9, 2021 13:37
michaelbeaumont added a commit that referenced this pull request Feb 12, 2021
@michaelbeaumont
Revert "Add v prefix to eksctl tags (#3241)"
a93a072 
This reverts commit 3940689.
michaelbeaumont added a commit that referenced this pull request Feb 12, 2021
@michaelbeaumont
Revert "Add v prefix to eksctl tags (#3241)"
5392c93 
This reverts commit 3940689.
michaelbeaumont added a commit that referenced this pull request Feb 12, 2021
@michaelbeaumont
Revert "Add v prefix to eksctl tags (#3241)"
4882c25 
This reverts commit 3940689.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

Assignees
No one assigned
Labels
area/build-and-release skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelbeaumont @cPu1 @weaveworksbot