Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update maxpods with p4d.24xlarge #2715

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Update maxpods with p4d.24xlarge #2715

merged 1 commit into from
Oct 8, 2020

Conversation

ajayk
Copy link
Contributor

@ajayk ajayk commented Oct 7, 2020

Description

autogenerate maxpods p4d.24xlarge

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@ajayk
Copy link
Contributor Author

ajayk commented Oct 7, 2020

@michaelbeaumont adding labels doesn't show up when i open up a PR ?

@michaelbeaumont michaelbeaumont changed the title autogenerate maxpods for p4d.24xlarge Update maxpods for p4d.24xlarge Oct 8, 2020
@michaelbeaumont michaelbeaumont merged commit 9c50a82 into eksctl-io:master Oct 8, 2020
@michaelbeaumont michaelbeaumont changed the title Update maxpods for p4d.24xlarge Update maxpods with p4d.24xlarge Oct 8, 2020
@ajayk ajayk deleted the max-pods-p4d branch October 8, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

Assignees
No one assigned
Labels
kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajayk @michaelbeaumont