Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate static AMI resolver #2710

Merged
merged 5 commits into from
Oct 8, 2020
Merged

Deprecate static AMI resolver #2710

merged 5 commits into from
Oct 8, 2020

Conversation

neha-viswanathan
Copy link
Contributor

Description

This MR contains a warning in the command description of create nodegroup to warn about the deprecation of the static AMI resolver.
Related to #2661

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@neha-viswanathan
Copy link
Contributor Author

@michaelbeaumont @martina-if please review. Thanks!

@neha-viswanathan neha-viswanathan mentioned this pull request Oct 5, 2020
Merged
5 tasks
michaelbeaumont
michaelbeaumont suggested changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a warning should be printed when we see the user is using the resolver here:
https://github.com/weaveworks/eksctl/blob/eff895ad956766480fb916de910e49036af15807/pkg/eks/api.go#L277-L278

@michaelbeaumont michaelbeaumont added kind/docs User documentation skip-release-notes Causes PR not to show in release notes labels Oct 7, 2020
@ajayk ajayk mentioned this pull request Oct 7, 2020
Closed
5 tasks
@michaelbeaumont michaelbeaumont changed the title post a warning about deprecating static AMI resolver Deprecate static AMI resolver Oct 8, 2020
cPu1
cPu1 approved these changes Oct 8, 2020
View reviewed changes
@michaelbeaumont @cPu1
Update pkg/eks/api.go
44e0b75 
Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com>
@michaelbeaumont michaelbeaumont merged commit b55beac into eksctl-io:master Oct 8, 2020
@michaelbeaumont michaelbeaumont mentioned this pull request Oct 14, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

@cPu1 cPu1 cPu1 approved these changes

Assignees
No one assigned
Labels
kind/docs User documentation skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neha-viswanathan @michaelbeaumont @cPu1